-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate v1 primitives #12497
Comments
related to #11490 |
I'm putting this PR |
After some off line conversations, we agree too:
|
How about other items in the PR #12575 (comment), e.g.,
|
- Revert BaseSamplerV1 and BaseEstimatorV1 - Deprecate BaseSampler and BaseEstimator Qiskit#12497 (comment)
Given that For |
I have a concern to rename |
* Deprecate V1 Primitives and their utils * Fix tests * Fix yaml error * Fix build * Fix error after mc * Fix error after mc * Apply comments * Use correct deprecate version for warning message * Update deprecation messages * Add missed `` * update releasenote * Deprecate SamplerResult and EstimatorResult * fix deprecation warning for SamplerResult and EstimatorResult * apply review comments Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * Applying the agreement of deprecations. - Revert BaseSamplerV1 and BaseEstimatorV1 - Deprecate BaseSampler and BaseEstimator #12497 (comment) * revert SamplerResult, EstimatorResult, and BasePrimitiveResult * fix test_backend_sampler * revert tox.ini * revise deprecation warning for BaseSampler and BaseEstimator * update reno * revert BaseSampler and BaseEstimator --------- Co-authored-by: Takashi Imamichi <imamichi@jp.ibm.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
* Deprecate V1 Primitives and their utils * Fix tests * Fix yaml error * Fix build * Fix error after mc * Fix error after mc * Apply comments * Use correct deprecate version for warning message * Update deprecation messages * Add missed `` * update releasenote * Deprecate SamplerResult and EstimatorResult * fix deprecation warning for SamplerResult and EstimatorResult * apply review comments Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * Applying the agreement of deprecations. - Revert BaseSamplerV1 and BaseEstimatorV1 - Deprecate BaseSampler and BaseEstimator Qiskit#12497 (comment) * revert SamplerResult, EstimatorResult, and BasePrimitiveResult * fix test_backend_sampler * revert tox.ini * revise deprecation warning for BaseSampler and BaseEstimator * update reno * revert BaseSampler and BaseEstimator --------- Co-authored-by: Takashi Imamichi <imamichi@jp.ibm.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
What should we add?
We should have deprecated V1 primitives in Qiskit 1.1, given its replacement (v2) had co-existed for 1 minor release. We should make sure it's deprecated in 1.2.
cc @t-imamichi, @ihincks
The text was updated successfully, but these errors were encountered: