Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local testing mode support for V2 primitivse #1533

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Mar 18, 2024

Summary

Add local testing mode support for V2 primitives (similar to #1495).

Details and comments

If an unsupported option is passed to a V2 primitive, a warning is issued. This was not done for V1 because V1 hard codes defaults, so there was no way to differentiate user-set vs defaulted to values. V2 clears out all unset options prior to calling the service.

There is also no release note because the one from #1495 is generic enough to cover both.

@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8333964509

Details

  • 53 of 54 (98.15%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 83.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/fake_provider/local_service.py 28 29 96.55%
Totals Coverage Status
Change from base Build 8333874776: 0.1%
Covered Lines: 6163
Relevant Lines: 7383

💛 - Coveralls

@jyu00 jyu00 marked this pull request as ready for review March 18, 2024 21:36
@jyu00 jyu00 requested review from kt474 and mberna March 18, 2024 22:05
@jyu00 jyu00 merged commit dc294e2 into Qiskit:main Mar 19, 2024
20 checks passed
@jyu00 jyu00 deleted the local-mode-v2-primitives branch March 19, 2024 13:09
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Mar 21, 2024
@kt474 kt474 added this to the 0.22.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants