Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local mode for v1 primitives #1495

Merged
merged 14 commits into from
Mar 15, 2024
Merged

Add local mode for v1 primitives #1495

merged 14 commits into from
Mar 15, 2024

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Mar 8, 2024

Summary

Support a "local testing mode" by allowing fake and Aer backends passed to primitives. This currently only works with V1 primitive because there is no BackendPrimitive for V2 yet.

Details and comments

Fixes #

@coveralls
Copy link

coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 8301172579

Details

  • 142 of 153 (92.81%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 82.67%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/runtime_options.py 6 9 66.67%
qiskit_ibm_runtime/session.py 43 46 93.48%
qiskit_ibm_runtime/fake_provider/local_service.py 62 67 92.54%
Totals Coverage Status
Change from base Build 8300740061: 0.4%
Covered Lines: 5877
Relevant Lines: 7109

💛 - Coveralls

@jyu00
Copy link
Collaborator Author

jyu00 commented Mar 14, 2024

I'd like to merge FakeProvider into QiskitRuntimeLocalService, but that'll be a separate PR

@jyu00 jyu00 marked this pull request as ready for review March 14, 2024 20:13
@jyu00 jyu00 requested a review from kt474 March 14, 2024 20:13
@jyu00 jyu00 added the Changelog: New Feature Include in the Added section of the changelog label Mar 14, 2024
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor typos

@jyu00 jyu00 merged commit 0106964 into Qiskit:main Mar 15, 2024
20 checks passed
@jyu00 jyu00 deleted the local-mode branch March 15, 2024 20:01
@kt474 kt474 added this to the 0.22.0 milestone Mar 21, 2024
@maniraman-periyasamy
Copy link

maniraman-periyasamy commented Apr 10, 2024

Does the local mode supports error-mitigation such as ZNE (resilience_level=2) ? I could not find this information in the documentation. Adding the information in the migration guide will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants