-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_component_data_iter now uses sorted_robust #1852
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1852 +/- ##
=======================================
Coverage 79.69% 79.69%
=======================================
Files 560 560
Lines 69822 69828 +6
=======================================
+ Hits 55646 55652 +6
Misses 14176 14176
Continue to review full report at Codecov.
|
Pulled from Pyomo#1852 by @PierreAttard.
We definitely need to move to using |
Extend sorted_robust API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending successful tests
Unfortunately, no. GHA only supports "rerun everything". We will wait to see if everything else passes, and if it does, I would be comfortable merging even with those failures (as they are unrelated to this PR). |
Fixes # .
Fix #1845
Summary/Motivation:
This resolves an issue with sorted_robust reported by @emma58 in #1845.
Block._component_data_iter does not use the correction did @jsiirola in the PR #1842. I just add his correction to the current PR in order to solve #1845.
Changes proposed in this PR:
sorted_robust
API to acceptkey=
andreverse=
argumentssorted_robust
in block.py and sort withsorted_robust
instead ofsix.itemgetter
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: