Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
The idea of your PR is generlly good, however, the sort in
_component_data_iter
really needs to use theitemgetter(0)
so that sorting doesn't accidentally compare component data objects (the second item in the tuple).This PR updates the
sorted_robust()
API so that it supports thekey=
andreverse=
arguments and puts the `itemgetter)0) back in. ...plus this adds a test of the problematic behavior from Pyomo#1845Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: