Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch version and print #17

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Patch version and print #17

merged 5 commits into from
Nov 8, 2023

Conversation

seb5g
Copy link
Contributor

@seb5g seb5g commented Nov 8, 2023

solve issue #16

  • etch correct package version (from VERSION file)
  • don't use the pre/post release tags when checking if pymodaq version in package specifiers
  • moved the fetching into a thread
  • display info from fetching directly into the UI (not freezing due to the multithread approach)

@seb5g seb5g linked an issue Nov 8, 2023 that may be closed by this pull request
Issues in 4.1.0 #16
Closed
@seb5g seb5g requested a review from rgeneaux November 8, 2023 10:29
rgeneaux
rgeneaux suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@rgeneaux rgeneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the version number does not work because when we install from pip, the VERSION file does not exist in the site-packages\pymodaq_plugin_manager folder!

@seb5g
Copy link
Contributor Author

seb5g commented Nov 8, 2023

I modified the manifest file in order to include in installation folder everything that is with the src folder.

@seb5g seb5g requested a review from rgeneaux November 8, 2023 12:05
rgeneaux
rgeneaux approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@rgeneaux rgeneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works, thanks!

Small error message in terminal remains but it doesn't look too important (things work fine despite it)

QObject::connect: Cannot queue arguments of type 'QTextCursor'
(Make sure 'QTextCursor' is registered using qRegisterMetaType().)

@seb5g seb5g merged commit 4ccf506 into main Nov 8, 2023
@seb5g seb5g deleted the patch_version_and_print branch November 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgeneaux rgeneaux rgeneaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues in 4.1.0
2 participants
@seb5g @rgeneaux