Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in 4.1.0 #16

Closed
rgeneaux opened this issue Nov 7, 2023 · 1 comment · Fixed by #17
Closed

Issues in 4.1.0 #16

rgeneaux opened this issue Nov 7, 2023 · 1 comment · Fixed by #17
Assignees

Comments

@rgeneaux
Copy link
Contributor

rgeneaux commented Nov 7, 2023

Hi, a few bug reports of the plugin manager in pymdoaq == 4.1.0b0

  • parsing error of plugin_manager version, fixed by parse manager version correctly #15

  • the "Check updates" button always returns "there is a newer version available !"
    indeed when reading the current plugin_manager version, we execute
    from pymodaq_plugin_manager import __version__ as version
    which ends reading the value in 'data/PluginList.json'
    for me, this value is 0.0.17 regardless of the actual manager version, so the manager always thinks there is a newer version

  • The list of available plugins is always empty in 4.1.0b0!
    This is because on line 158 of validate.py, pymodaq_version in specifier returns False for pymodaq_version =Version('4.1.0b0') and specifier = '>=4.0' . But it works with pymodaq_version =Version('4.1.0') ("b0" is the issue).

@seb5g
Copy link
Contributor

seb5g commented Nov 8, 2023

I'm looking at it now

@seb5g seb5g self-assigned this Nov 8, 2023
@seb5g seb5g linked a pull request Nov 8, 2023 that will close this issue
@seb5g seb5g closed this as completed in #17 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants