Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python_bundle_workflow #1656

Merged
merged 11 commits into from
Mar 6, 2024
Merged

Update python_bundle_workflow #1656

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3be3f85
remove `self._set_prop`
KumoLiu Feb 28, 2024
013a8bf
remove self._probs in initialize
KumoLiu Feb 29, 2024
cf74488
Revert "remove `self._set_prop`"
KumoLiu Mar 1, 2024
84e7629
Revert "remove self._probs in initialize"
KumoLiu Mar 1, 2024
bc610f1
address comments
KumoLiu Mar 1, 2024
07e155e
Merge branch 'main' into bundle
KumoLiu Mar 1, 2024
5bc6ffe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 1, 2024
e0eb904
DCO Remediation Commit for YunLiu <55491388+KumoLiu@users.noreply.git…
KumoLiu Mar 1, 2024
4d713f8
Merge branch 'bundle' of https://github.com/KumoLiu/tutorials into bu…
KumoLiu Mar 1, 2024
e94cf15
address comments
KumoLiu Mar 4, 2024
5a4d80c
address comments
KumoLiu Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions bundle/python_bundle_workflow/scripts/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,10 @@ def __init__(self, dataset_dir: str = "."):
nib.save(n, os.path.join(dataset_dir, f"seg{i:d}.nii.gz"))

self._props = {}
self._set_props = {}
self.dataset_dir = dataset_dir

def initialize(self):
self.props = {}
pass

def run(self):
self.evaluator.run()
Expand All @@ -76,7 +75,7 @@ def finalize(self):
pass

def _set_property(self, name, property, value):
self._set_props[name] = value
self._props[name] = value

def _get_property(self, name, property):
"""
Expand All @@ -90,9 +89,6 @@ def _get_property(self, name, property):
value = None
if name in self._props:
value = self._props[name]
elif name in self._set_props:
value = self._set_props[name]
self._props[name] = value
else:
try:
value = getattr(self, f"get_{name}")()
Expand Down
7 changes: 1 addition & 6 deletions bundle/python_bundle_workflow/scripts/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ def __init__(self, dataset_dir: str = "."):

# define buckets to store the generated properties and set properties
self._props = {}
self._set_props = {}
self.dataset_dir = dataset_dir

# besides the predefined properties, this bundle workflow can also provide `network`, `loss`, `optimizer`
Expand All @@ -82,7 +81,6 @@ def __init__(self, dataset_dir: str = "."):

def initialize(self):
set_determinism(0)
self.props = {}

def run(self):
self.trainer.run()
Expand All @@ -91,7 +89,7 @@ def finalize(self):
set_determinism(None)

def _set_property(self, name, property, value):
self._set_props[name] = value
self._props[name] = value

def _get_property(self, name, property):
"""
Expand All @@ -105,9 +103,6 @@ def _get_property(self, name, property):
value = None
if name in self._props:
value = self._props[name]
elif name in self._set_props:
value = self._set_props[name]
self._props[name] = value
else:
try:
value = getattr(self, f"get_{name}")()
Expand Down
Loading