-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python_bundle_workflow
#1656
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine to change unless there's a use for _set_props
I don't see. @Nic-Ma any thoughts? Thanks!
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Nic-Ma is this being used somewhere or will be? If it is we should write a bit more commentary since the semantics wasn't so clear. If not and won't ever be used I would take it out. Thanks! |
Hi @ericspod , There is a typical use-case: if we want to set the bundle idle on GPU and run inference for every input image, we can only override the Thanks. |
This reverts commit 3be3f85.
This reverts commit 013a8bf.
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci
Hi @ericspod, To aid understanding and also added as a note, I've provided a brief example.
|
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a comment about the swapped order of the if-conditions in both classes, but the other changes look good to me so I can approve now and leave it up to you to swap the order of conditions or not. Thanks!
Fixes # . ### Description - add description for `self._set_prop` in python `python_bundle_workflow`. - remove generate data outside of the Workflow class. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes # .
Description
self._set_prop
in pythonpython_bundle_workflow
.Checks
./figure
folder./runner.sh -t <path to .ipynb file>