Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature added: Get WSI at mpp #7574

Open
wants to merge 34 commits into
base: dev
Choose a base branch
from

Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp

ca6796b
Select commit
Loading
Failed to load commit list.
Open

Feature added: Get WSI at mpp #7574

Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
ca6796b
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Jan 8, 2025 in 1s

DCO

There are 11 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Preferred method: Commit author adds a DCO remediation commit

A DCO Remediation Commit contains special text in the commit message that applies a missing Signed-off-by line in a subsequent commit. The primary benefit of this method is that the project’s history does not change, and there is no risk of breaking someone else’s work.

These authors can unblock this PR by adding a new commit to this branch with the following text in their commit message:

Juampa <1523654+juampatronics@users.noreply.github.com>

DCO Remediation Commit for Juampa <1523654+juampatronics@users.noreply.github.com>

I, Juampa <1523654+juampatronics@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 3264079906ffa02055c80eb427f7157fd398b151

Signed-off-by: Juampa <1523654+juampatronics@users.noreply.github.com>

Nikolas Schmitz <nikschmitz@ukaachen.de>

DCO Remediation Commit for Nikolas Schmitz <nikschmitz@ukaachen.de>

I, Nikolas Schmitz <nikschmitz@ukaachen.de>, hereby add my Signed-off-by to this commit: f3e7d03d93b30a79a37581108067e6bb8f428c94
I, Nikolas Schmitz <nikschmitz@ukaachen.de>, hereby add my Signed-off-by to this commit: 88002e8a91d6466a2fdcb60a19b8cd1ed9e89558
I, Nikolas Schmitz <nikschmitz@ukaachen.de>, hereby add my Signed-off-by to this commit: a9fe772d56a458c853bbb69ecef4585cb2ef564d
I, Nikolas Schmitz <nikschmitz@ukaachen.de>, hereby add my Signed-off-by to this commit: feac0dc57ef2cc6fd3f24204d43881fd186c5595
I, Nikolas Schmitz <nikschmitz@ukaachen.de>, hereby add my Signed-off-by to this commit: 81940261f2c35ae5f8c4485054523b9306a3eeff

Signed-off-by: Nikolas Schmitz <nikschmitz@ukaachen.de>

Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>

DCO Remediation Commit for Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>

I, Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>, hereby add my Signed-off-by to this commit: 6fcc4a6995a012fca2d6a7928ec0ff64ce9672c3
I, Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>, hereby add my Signed-off-by to this commit: 4b0c9baf6a31b4fac7056e79381dc62a85809fef
I, Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>, hereby add my Signed-off-by to this commit: 441b4629f8905dba1fecbc16bb303c0c86f7ff17
I, Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>, hereby add my Signed-off-by to this commit: d73d739de08101dc3781f3cf06cd862a8a775e16
I, Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>, hereby add my Signed-off-by to this commit: 59683bc07cef236bbe4a61129fa6f963533f217c

Signed-off-by: Nikolas Schmitz <nikolas.schmitz@rwth-aachen.de>

Please note: You should avoid adding empty commits (i.e., git commit -s --allow-empty), because these will be discarded if someone rebases the branch / repo.


Least preferred method: Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~34 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin 4980-get-wsi-at-mpp

Summary

Commit sha: 3264079, Author: Juampa, Committer: Nikolas Schmitz; Can not find "Juampa 1523654+juampatronics@users.noreply.github.com", in ["Juan Pablo de la Cruz Gutiérrez juampatronics@gmail.com", "monai-bot monai.miccai2019@gmail.com", "elitap elias.tappeiner@gmx.at", "Felix Schnabel f.schnabel@tum.de", "YanxuanLiu yanxuanl@nvidia.com", "ytl0623 david89062388@gmail.com", "Dženan Zukić dzenan.zukic@kitware.com", "KumoLiu yunl@nvidia.com", "YunLiu 55491388+KumoLiu@users.noreply.github.com", "Ishan Dutta ishandutta0098@gmail.com", "dependabot[bot] support@github.com", "kaibo ktang@unc.edu", "heyufan1995 heyufan1995@gmail.com", "binliu binliu@nvidia.com", "axel.vlaminck axel.vlaminck@gmail.com", "Ibrahim Hadzic ibrahimhadzic45@gmail.com", "Behrooz 3968947+drbeh@users.noreply.github.com", "Timothy Baker bakertim@umich.edu", "Mathijs de Boer m.deboer-41@umcutrecht.nl", "Fabian Klopfer fabian.klopfer@ieee.org", "Lucas Robinet robinet.lucas@iuct-oncopole.fr", "Lucas Robinet 67736918+Lucas-rbnt@users.noreply.github.com", "chaoliu chaoliu@nvidia.com", "cxlcl chaoliucxl@gmail.com", "chaoliu chaoliucxl@gmail.com"].
Commit sha: f3e7d03, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: 88002e8, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: a9fe772, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: feac0dc, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: 8194026, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: 6fcc4a6, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: 4b0c9ba, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: 441b462, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: d73d739, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.
Commit sha: 59683bc, Author: Nikolas Schmitz, Committer: Nikolas Schmitz; The sign-off is missing.