Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where not providing a password causes a failure on deploy #97

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Fix issue where not providing a password causes a failure on deploy #97

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3cb34c2
Fix no password error
jimid27 Dec 13, 2022
330da27
Add platform team
jimid27 Dec 13, 2022
86872cc
Update maintainers on both charts
jimid27 Dec 13, 2022
cda2c3a
Update maintainers on both charts
jimid27 Dec 13, 2022
5881d05
Update charts/prefect-orion/values.yaml
jamiezieziula Dec 13, 2022
1a2ae56
docs
jamiezieziula Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions charts/prefect-agent/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ description: Prefect Agent application bundle
engine: gotpl
home: https://github.com/PrefectHQ
maintainers:
- name: gabcoyne
email: george@prefect.io
- name: jamiezieziula
email: jamie@prefect.io
- name: jimid27
email: jimi@prefect.io
- name: parkedwards
email: edward@prefect.io
- name: jawnsy
email: jonathan@prefect.io
name: prefect-agent
sources:
- https://github.com/PrefectHQ/prefect-helm
Expand Down
4 changes: 3 additions & 1 deletion charts/prefect-agent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ Prefect Agent application bundle

| Name | Email | Url |
| ---- | ------ | --- |
| gabcoyne | <george@prefect.io> | |
| jamiezieziula | <jamie@prefect.io> | |
| jimid27 | <jimi@prefect.io> | |
| parkedwards | <edward@prefect.io> | |
| jawnsy | <jonathan@prefect.io> | |

## Source Code

Expand Down
8 changes: 6 additions & 2 deletions charts/prefect-orion/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,14 @@ description: Prefect orion application bundle
engine: gotpl
home: https://github.com/PrefectHQ
maintainers:
- name: gabcoyne
email: george@prefect.io
- name: jamiezieziula
email: jamie@prefect.io
- name: jimid27
email: jimi@prefect.io
- name: parkedwards
email: edward@prefect.io
- name: jawnsy
email: jonathan@prefect.io
name: prefect-orion
sources:
- https://github.com/PrefectHQ/prefect-helm
Expand Down
4 changes: 3 additions & 1 deletion charts/prefect-orion/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ Prefect orion application bundle

| Name | Email | Url |
| ---- | ------ | --- |
| gabcoyne | <george@prefect.io> | |
| jamiezieziula | <jamie@prefect.io> | |
| jimid27 | <jimi@prefect.io> | |
| parkedwards | <edward@prefect.io> | |
| jawnsy | <jonathan@prefect.io> | |

## Source Code

Expand Down
2 changes: 1 addition & 1 deletion charts/prefect-orion/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Create the name of the service account to use
*/}}
{{- define "orion.postgres-connstr" -}}
{{- $user := .Values.postgresql.auth.username -}}
{{- $pass := .Values.postgresql.auth.password -}}
{{- $pass := .Values.postgresql.auth.password | required ".Values.postgresql.auth.password is required." -}}
{{- $host := include "orion.postgres-hostname" . -}}
{{- $port := .Values.postgresql.containerPorts.postgresql | toString -}}
{{- $db := .Values.postgresql.auth.database -}}
Expand Down
5 changes: 4 additions & 1 deletion charts/prefect-orion/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ ingress:
postgresql:
enabled: true
auth:
# -- determines whether an admin user is created within postgres
enablePostgresUser: false
# -- name for a custom database to create
database: orion
# -- name for a custom user to create
Expand All @@ -224,8 +226,9 @@ postgresql:
# -- password for the custom user to create. Ignored if `auth.existingSecret` with key `password` is provided
password: ""

## This secret must contain a key-value pair where the key is `connection-string` and the value is the
## This secret must contain two key-value pairs where the first key is `connection-string` and the value is the
## connection string containing your password (e.g. postgresql+asyncpg://{username}:{password}@{hostname}/{database}).
## The second key-value pair has the key `password` and the value is the {password} used in the connection string
# -- Name of existing secret to use for PostgreSQL credentials.
existingSecret: null

Expand Down