Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where not providing a password causes a failure on deploy #97

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Fix issue where not providing a password causes a failure on deploy #97

merged 6 commits into from
Dec 13, 2022

Conversation

jimid27
Copy link
Contributor

@jimid27 jimid27 commented Dec 13, 2022 •
edited by jamiezieziula
Loading

  • Update to require a password to be set when no existing password secret is provided
  • Update description for creating a secret to be used in the existingSecret block with correct information
  • Update maintainers list

Closes #92

@jimid27 jimid27 requested review from gabcoyne, zanieb and a team as code owners December 13, 2022 22:16
jamiezieziula
jamiezieziula previously approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@jamiezieziula jamiezieziula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor change!

parkedwards
parkedwards previously approved these changes Dec 13, 2022
View reviewed changes
@jamiezieziula jamiezieziula dismissed stale reviews from parkedwards and themself via 1a2ae56 December 13, 2022 22:29
@jimid27 jimid27 merged commit f111427 into main Dec 13, 2022
@jimid27 jimid27 deleted the fix-fail-no-password branch December 13, 2022 22:56
@jawnsy
Copy link
Contributor

jawnsy commented Dec 13, 2022

Thanks for fixing this so quickly, @jimid27 & @jamiezieziula! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiezieziula jamiezieziula jamiezieziula approved these changes

@parkedwards parkedwards parkedwards left review comments

@gabcoyne gabcoyne Awaiting requested review from gabcoyne

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default installation stuck in CrashLoopBackOff
4 participants
@jimid27 @jawnsy @parkedwards @jamiezieziula