Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing breakdown bug with retrieving top elements #4313

Merged
merged 16 commits into from
May 28, 2021
Merged

Fixing breakdown bug with retrieving top elements #4313

merged 16 commits into from
May 28, 2021
+266 −139

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented May 12, 2021 •
edited
Loading

Changes

Please describe.

  • addresses Breakdown by attribute property is broken #4309
  • previously the query that retrieves the top properties to use in the breakdown query did not have an event clause so it was selecting top properties across all events for that team
  • this fix will speed up the breakdown query and be correct now
  • TODO: need to figure out null condition/"other values" condition because it's handled differently between pg and clickhouse
    If this affects the frontend, include screenshots.

Checklist

  • Need to add/adjust tests

@timgl timgl temporarily deployed to posthog-pr-4313 May 12, 2021 02:45 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-4313 May 13, 2021 18:07 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-4313 May 13, 2021 18:13 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-4313 May 13, 2021 18:24 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review May 25, 2021 17:36
@EDsCODE EDsCODE requested a review from buwilliams May 25, 2021 17:36
@EDsCODE EDsCODE requested a review from timgl May 26, 2021 19:35
buwilliams
buwilliams approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@buwilliams buwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a cursory look.

@EDsCODE EDsCODE merged commit 7471ade into master May 28, 2021
@EDsCODE EDsCODE deleted the 4309-breakdown-elements-bug branch May 28, 2021 14:24
@EDsCODE EDsCODE mentioned this pull request Jun 4, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buwilliams buwilliams buwilliams approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @buwilliams @timgl