Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakdown by attribute property is broken #4309

Closed
1 of 2 tasks
buwilliams opened this issue May 11, 2021 · 6 comments
Closed
1 of 2 tasks

Breakdown by attribute property is broken #4309

buwilliams opened this issue May 11, 2021 · 6 comments
Labels
bug Something isn't working right P1 Urgent, non-breaking (no crash but low usability) stale

Comments

@buwilliams
Copy link
Contributor

Bug description

Original bug report

Video of problem

  • filtering OUT internal users increases the event count
  • filtering OUT internal users increases the event count

Expected behavior

  • Event counts are correct.

How to reproduce

See video above.

Environment

  • PostHog Cloud
  • self-hosted PostHog, version/commit: please provide

Additional context

Originated from customer via Slack.

@buwilliams buwilliams added the bug Something isn't working right label May 11, 2021
@EDsCODE
Copy link
Member

EDsCODE commented May 13, 2021

Need help deciding best way to decide which properties to include on breakdown. Currently, when breaking down given a single event, it's clear that it will be most helpful to find the top X values of the breakdown property requested and then give the breakdown of the event on those values. For example, if the event is $pageview and the breakdown property is 'city', we would breakdown across the top 20 cities where $pageviews have been happening.

However, when provided multiple events (for example: $pageviews and $user_signed_up), the top 20 cities for each event could be different. Do we display this as is? Or is there a better way to decide on these values

@EDsCODE
Copy link
Member

EDsCODE commented May 18, 2021

Will proceed with displaying the top 20 per event as this makes the most sense in displaying relevant numbers

@EDsCODE EDsCODE added the P1 Urgent, non-breaking (no crash but low usability) label Aug 2, 2021
@macobo
Copy link
Contributor

macobo commented Aug 7, 2021

@EDsCODE what's the state here? What needs to be done, is there a WIP branch somewhere, should someone else on the team pick it up?

@EDsCODE
Copy link
Member

EDsCODE commented Aug 10, 2021

I think I was about to pick this up but got hung up on a different sprint and then we hopped into funnels mode. It's open for tackling. Mainly just need to make sure breakdown values are correctly determined per event and that this is clear on the UI. Applicable for funnels too

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right P1 Urgent, non-breaking (no crash but low usability) stale
Projects
None yet
Development

No branches or pull requests

5 participants