Enable plugins for everyone

[Twixes]

Changes

This deprecates Team.plugins_opt_in. Plugins will be enabled for everyone on self-hosted and enabled or disabled based on other variables on Cloud (pending #3328).

Checklist

• All querysets/queries filter by Organization, by Team, and by User
• Django backend tests
• Jest frontend tests
• Cypress end-to-end tests

[weyert]

So exciting the deployment looking promising :D

[mariusandra]

Are we sure we already want to remove "BETA"? Still some things to fix in the plugin system before I'm ready to declare that...

[Twixes]

Hm, maybe not necessarily in this PR… Though the goal for 1.23 is to indeed put plugins out of beta. Is there something you'd consider a blocker that is not included in our release priorities as they stand?

[mariusandra]

Once the issues in the release are done (mainly lazy vms and access control... and maybe logs?), we're out of beta (and maybe some other things from this list.

The problem is that some deployments/users deploy from master who will be out of beta, even though we're still beta :). Then again, it's just a label so feel free to remove.

[Twixes]

Yeah, we'll merge this after the solutions for things you mentioned.

[Twixes]

I added two shiny things to mark the end of beta for users:

• A blip shown on the Plugins navigation item. Hidden on the device after user views the Plugins page once.
  

• A banner shown on the Plugins page. Hidden on the device after user clicks "X" to close.
  

I'm advocating for a marketing-type blog post on Plugins, explaining rationale for making this a core feature, its utility, how easy it is to write your own plugin – something of that sort.

[Twixes]

Opted for a crossdevice solution replacing local posthog.persistence with a new field on the User model: flags - a schemaless dict saved as JSON, for keeping track of such small things for which whole new schema fields would be overkill, but which nevertheless are much better saved on the User instance.

[avorio]

@Twixes @mariusandra Thanks for the fabulous work you folks are doing here.

I've got a question: my plugin server is not working, as described in this issue. It's the only item showing a red "NO" in the system status page. However, I have also noticed that my events stopped appearing in PostHog after I upgraded to the latest version of PostHog, 1.22.0. Am I losing data since that upgrade? According to the release notes, the plugin server was going to be mandatory in the next release, which I understood to be 1.23.0.

How can I get out of this, please? Many-many thanks.

[macobo]

Added some notes.

The weakest part here imo is the "highlight" or tutorials approach. Seems like something we'll likely solve elsehow at some point. Did you intend for this to be a more permanent solution?

[mariusandra]

I'd scale this down... and just silently remove the plugins_opt_in code without any ceremony. Introducing a new field flags on users to store a toggle and all this alerting seems like over-engineering to me. Removing the danger zone and the opt-in screen is definitely something we want to do, but I'm not convinced on the other parts.

I think that plugins are also not yet ready to go out of BETA. I'd keep the label around still for some time to slightly deflect blame in case something is not working well (e.g. we have no retries, etc).

[Twixes]

Scaled down @mariusandra

[mariusandra]

LGTM