Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out plugins fully #3291

Closed
wants to merge 3 commits into from
Closed

Roll out plugins fully #3291

wants to merge 3 commits into from

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Feb 10, 2021

Changes

I needed this to test something locally, but will also be useful when we move everyone to plugin server ingestion.
Removes PLUGINS_CLOUD_WHITELISTED_ORG_IDS and allows plugin server ingestion on FOSS deployments.

@timgl timgl temporarily deployed to posthog-full-plugin-ser-mvvsbu February 10, 2021 13:56 Inactive
@mariusandra
Copy link
Collaborator

This rolls out plugins fully-fully, yet for cloud we need to have some level of access control at the organization level.

There will be four levels of access we need to grant for plugins:

  1. Global access. You can install plugins for your organisation and enable them per project. You can also toggle a boolean global on any installed plugin that will make it available for all organisations to use. On cloud our organisation (or a secure "plugin control" organisation) will have this access and use it to keep everyone's default plugins up to date.
  2. Install access. You can install plugins for your organisation and enable them per project. I suspect we will eventually give this access to some EE customers on cloud, who will be installing their own custom plugins. They'll still have access to the globally installed plugins.
  3. Configuration access. You can enable installed plugins. This we would eventually turn on for everyone on cloud.
  4. No plugin access, but still ingesting events via the plugin server. Default for new accounts on cloud for now.

What's the best way to make this happen? I imagine environment variables are not the nicest interface and we need some booleans on organization? Who should be able to toggle them and where?

@Twixes
Copy link
Member Author

Twixes commented Mar 4, 2021

#3486 and #3557 replace this with more adequately nuanced solutions. :)

@Twixes Twixes closed this Mar 4, 2021
@Twixes Twixes deleted the full-plugin-server-ingestion branch March 4, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants