Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flags): Stop deleting flags when experiment is deleted #29090

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −7
Open

chore(flags): Stop deleting flags when experiment is deleted #29090

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
191e402
chore(flags): Stop deleting flags when experiment is deleted
havenbarnes Feb 21, 2025
8d073fd
Merge branch 'master' into chore/remove-experiment-ff-cascade-deletion
havenbarnes Feb 21, 2025
c0cdb22
Merge branch 'master' into chore/remove-experiment-ff-cascade-deletion
havenbarnes Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions posthog/models/feature_flag/feature_flag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from django.core.cache import cache
from django.db import models
from django.db.models.signals import post_delete, post_save, pre_delete
from django.db.models.signals import post_delete, post_save
from django.utils import timezone
from posthog.exceptions_capture import capture_exception

Expand All @@ -14,7 +14,6 @@
PropertyOperatorType,
)
from posthog.models.cohort import Cohort, CohortOrEmpty
from posthog.models.experiment import Experiment
from posthog.models.property import GroupTypeIndex
from posthog.models.property.property import Property, PropertyGroup
from posthog.models.signals import mutable_receiver
Expand Down Expand Up @@ -358,11 +357,6 @@ def uses_cohorts(self) -> bool:
return False


@mutable_receiver(pre_delete, sender=Experiment)
def delete_experiment_flags(sender, instance, **kwargs):
FeatureFlag.objects.filter(experiment=instance).update(deleted=True)


@mutable_receiver([post_save, post_delete], sender=FeatureFlag)
def refresh_flag_cache_on_updates(sender, instance, **kwargs):
set_feature_flags_for_team_in_cache(instance.team.project_id)
Expand Down
Loading