chore(flags): Stop deleting flags when experiment is deleted #29090
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR removes the automatic soft deletion of feature flags when experiments are deleted, addressing a potentially dangerous hidden behavior in PostHog.
- Removed pre_delete signal handler in
/posthog/models/feature_flag/feature_flag.pythat was causing feature flags to be soft-deleted when associated experiments were deleted - Prevents unintended deletion of pre-existing feature flags that were later linked to experiments
- Improves system predictability by removing undocumented cascading deletion behavior
- Maintains feature flag independence from experiment lifecycle
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
nice ! |
dmarticus
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Context: https://posthog.slack.com/archives/C06UTAJJEHM/p1740121610717549
Deleting an experiment automatically soft deletes the linked feature flag. This is not documented anywhere during experiment creation, and for flags that are pre-existing before being linked to an experiment, this is especially dangerous hidden behavior.
Changes
Remove the pre_delete hook in the feature_flag model
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Validated no more cascading flag deletion after deleting an experiment
deleted_experiment.mp4