Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): better result refresh buttons #27586

Merged
merged 3 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 38 additions & 3 deletions frontend/src/scenes/experiments/ExperimentView/Info.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { IconWarning } from '@posthog/icons'
import { IconRefresh, IconWarning } from '@posthog/icons'
import { LemonButton, Link, ProfilePicture, Tooltip } from '@posthog/lemon-ui'
import { useActions, useValues } from 'kea'
import { CopyToClipboardInline } from 'lib/components/CopyToClipboard'
import { EditableField } from 'lib/components/EditableField/EditableField'
import { FEATURE_FLAGS } from 'lib/constants'
import { dayjs } from 'lib/dayjs'
import { IconOpenInNew } from 'lib/lemon-ui/icons'
import { urls } from 'scenes/urls'

Expand All @@ -15,8 +16,9 @@ import { StatusTag } from './components'
import { ExperimentDates } from './ExperimentDates'

export function Info(): JSX.Element {
const { experiment, featureFlags } = useValues(experimentLogic)
const { updateExperiment, setExperimentStatsVersion } = useActions(experimentLogic)
const { experiment, featureFlags, metricResults } = useValues(experimentLogic)
const { updateExperiment, setExperimentStatsVersion, loadMetricResults, loadSecondaryMetricResults } =
useActions(experimentLogic)

const { created_by } = experiment

Expand All @@ -26,6 +28,8 @@ export function Info(): JSX.Element {

const currentStatsVersion = experiment.stats_config?.version || 1

const lastRefresh = metricResults?.[0]?.last_refresh

return (
<div>
<div className="flex">
Expand Down Expand Up @@ -94,6 +98,37 @@ export function Info(): JSX.Element {

<div className="w-1/2 flex flex-col justify-end">
<div className="ml-auto inline-flex space-x-8">
{lastRefresh && (
<div className="block">
<div className="text-xs font-semibold uppercase tracking-wide">Last refreshed</div>
<div className="inline-flex space-x-2">
<span
className={`${
lastRefresh
? dayjs().diff(dayjs(lastRefresh), 'hours') > 12
? 'text-danger'
: dayjs().diff(dayjs(lastRefresh), 'hours') > 6
? 'text-warning'
: ''
: ''
}`}
>
{lastRefresh ? dayjs(lastRefresh).fromNow() : 'a while ago'}
</span>
<LemonButton
type="secondary"
size="xsmall"
onClick={() => {
loadMetricResults(true)
loadSecondaryMetricResults(true)
}}
data-attr="refresh-experiment"
icon={<IconRefresh />}
tooltip="Refresh experiment results"
/>
</div>
</div>
)}
<ExperimentDates />
<div className="block">
<div className="text-xs font-semibold uppercase tracking-wide">Created by</div>
Expand Down
14 changes: 1 addition & 13 deletions frontend/src/scenes/experiments/ExperimentView/components.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IconFlask, IconRefresh } from '@posthog/icons'
import { IconFlask } from '@posthog/icons'
import {
LemonBanner,
LemonButton,
Expand Down Expand Up @@ -263,8 +263,6 @@ export function PageHeaderCustom(): JSX.Element {
launchExperiment,
endExperiment,
archiveExperiment,
loadMetricResults,
loadSecondaryMetricResults,
createExposureCohort,
openShipVariantModal,
createExperimentDashboard,
Expand Down Expand Up @@ -317,16 +315,6 @@ export function PageHeaderCustom(): JSX.Element {
/>
<LemonDivider vertical />
</>
<LemonButton
type="secondary"
onClick={() => {
loadMetricResults(true)
loadSecondaryMetricResults(true)
}}
data-attr="refresh-experiment"
icon={<IconRefresh />}
tooltip="Refresh experiment results"
/>
<ResetButton experimentId={experiment.id} />
{!experiment.end_date && (
<LemonButton
Expand Down
Loading