feat(experiments): better result refresh buttons #27586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
andehen
approved these changes
Jan 16, 2025
| type="secondary" | ||
| size="xsmall" | ||
| onClick={() => { | ||
| if (isSecondary) { |
There was a problem hiding this comment.
I wonder if it would be better for the user if we refreshed both here as:
- this is likely what the user wants (it does not make sense to show update results for one but not the other)
- we currently do reload the whole result component so it kind of looks like both should be updated
There was a problem hiding this comment.
Good point :) fixed in 1a9b520 (#27586)
we currently do reload the whole result component
Yes but I want to fix this too, in a follow up
|
@danielbachhuber agree, makes sense! Moved it to the top bar 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prompted by @andehen: https://posthog.slack.com/archives/C07PXH2GTGV/p1736935461402799?thread_ts=1736935389.854549&cid=C07PXH2GTGV
How did you test this code?
👀