chore(python): update Python to version 3.8.14 #11713
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| # | ||
| # Build the frontend artifacts | ||
| # | ||
| FROM node:16.15-alpine3.16 AS frontend | ||
|
|
||
| WORKDIR /code | ||
|
|
||
|
|
@@ -24,16 +24,16 @@ RUN yarn build | |
| # Build the plugin-server artifacts. Note that we still need to install the | ||
| # runtime deps in the main image | ||
| # | ||
| FROM node:16.15-alpine3.16 AS plugin-server | ||
|
|
||
| WORKDIR /code/plugin-server | ||
|
|
||
| # Install python, make and gcc as they are needed for the yarn install | ||
| RUN apk --update --no-cache add \ | ||
| "make~=4.3" \ | ||
| "g++~=11.2" \ | ||
| "gcc~=11.2" \ | ||
| "python3~=3.10" | ||
|
|
||
| # Compile and install Yarn dependencies. | ||
| # | ||
|
|
@@ -54,7 +54,7 @@ RUN yarn build | |
|
|
||
| # Build the posthog image, incorporating the Django app along with the frontend, | ||
| # as well as the plugin-server | ||
| FROM python:3.8.14-alpine3.16 | ||
|
|
||
| ENV PYTHONUNBUFFERED 1 | ||
|
|
||
|
|
@@ -66,14 +66,14 @@ WORKDIR /code | |
| # If you temporary need a package to build a Python or npm | ||
| # dependency take a look at the sections below. | ||
| RUN apk --update --no-cache add \ | ||
| "libpq~=14" \ | ||
| "libxslt~=1.1" \ | ||
|
There was a problem hiding this comment. There isn't a nodejs v16 package available so I had to bump it to 18 There was a problem hiding this comment. cc @yakkomajuri @tiina303 and @macobo for visibility |
||
| "nodejs-current~=18" \ | ||
| "chromium~=102" \ | ||
| "chromium-chromedriver~=102" \ | ||
| "xmlsec~=1.2" | ||
|
|
||
| # Curl the GeoLite2-City database that will be used for IP geolocation within Django | ||
| # | ||
| # Notes: | ||
| # | ||
|
|
@@ -106,16 +106,15 @@ RUN apk --update --no-cache --virtual .geolite-deps add \ | |
| COPY requirements.txt ./ | ||
| RUN apk --update --no-cache --virtual .build-deps add \ | ||
| "bash~=5.1" \ | ||
| "g++~=11.2" \ | ||
| "gcc~=11.2" \ | ||
| "cargo~=1.60" \ | ||
| "git~=2" \ | ||
| "make~=4.3" \ | ||
| "libffi-dev~=3.4" \ | ||
| "libxml2-dev~=2.9" \ | ||
| "libxslt-dev~=1.1" \ | ||
| "xmlsec-dev~=1.2" \ | ||
|
There was a problem hiding this comment. This package doesn't exist in Alpine 3.15 and 3.16. I'll get the error at build and see which other package we could use There was a problem hiding this comment. The package has been renamed to |
||
| "libmaxminddb~=1.5" \ | ||
| && \ | ||
| pip install -r requirements.txt --compile --no-cache-dir \ | ||
|
|
@@ -148,7 +147,7 @@ RUN apk --update --no-cache add "yarn~=1" | |
|
|
||
| # NOTE: we need make and g++ for node-gyp | ||
| # NOTE: npm is required for re2 | ||
| RUN apk --update --no-cache add "make~=4.3" "g++~=11.2" "npm~=8" --virtual .build-deps \ | ||
| && yarn install --frozen-lockfile --production=true \ | ||
| && yarn cache clean \ | ||
| && apk del .build-deps | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| python-3.8.14 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update to 18 here? and for plugin-server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just wanted to have a 👍 from the ingestion team before doing so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. To be clear we'll be running plugin-server on node 18 now afaict just not the build. That's probably the right way around as should be backwards compat. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I'll make a PR