Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): update Python to version 3.8.14 #11713

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

guidoiaquinti
Copy link
Contributor

@guidoiaquinti guidoiaquinti commented Sep 7, 2022

Problem

We are running a version of Python (3.8.12) that has some security issues.

Changes

This PR upgrades CI and our container images to Python 3.8.14 released 2 days ago.

Note: as there isn't an image for Python 3.8.14 on Alpine 3.14, I've also updated the base image to 3.16 and as we are using a multistage build, I'm also upgrading the other base images and packages (yes, the change is way bigger than I thought).

How did you test this code?

CI is ✅

@guidoiaquinti guidoiaquinti changed the title chore(python): update Python to version 3.8.13 chore(python): update Python to version 3.8.14 Sep 8, 2022
"libxml2-dev~=2.9" \
"libxslt-dev~=1.1" \
"xmlsec-dev~=1.2" \
"postgresql-dev~=13" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package doesn't exist in Alpine 3.15 and 3.16. I'll get the error at build and see which other package we could use

Copy link
Contributor Author

@guidoiaquinti guidoiaquinti Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package has been renamed to postgresql13-dev

@guidoiaquinti guidoiaquinti marked this pull request as ready for review September 8, 2022 10:46
"libxslt~=1.1" \
"nodejs-current~=16" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a nodejs v16 package available so I had to bump it to 18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @yakkomajuri @tiina303 and @macobo for visibility

Copy link
Contributor

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -7,7 +7,7 @@
#
# Build the frontend artifacts
#
FROM node:16.15-alpine3.14 AS frontend
FROM node:16.15-alpine3.16 AS frontend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update to 18 here? and for plugin-server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just wanted to have a 👍 from the ingestion team before doing so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. To be clear we'll be running plugin-server on node 18 now afaict just not the build. That's probably the right way around as should be backwards compat. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I'll make a PR

@guidoiaquinti guidoiaquinti enabled auto-merge (squash) September 8, 2022 10:53
@guidoiaquinti guidoiaquinti merged commit 7175510 into master Sep 8, 2022
@guidoiaquinti guidoiaquinti deleted the python_upgrade branch September 8, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants