Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Menu): Change "toolbar" to "Launch Toolbar" #11406

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Aug 22, 2022

Problem

It's not obvious where you need to click to launch the toolbar

Changes

Change the menu item from Toolbar to Launch Toolbar
image

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@timgl timgl requested a review from mariusandra August 22, 2022 09:23
@Twixes Twixes requested a review from clarkus August 22, 2022 09:50
@clarkus
Copy link
Contributor

clarkus commented Aug 22, 2022

It's not just launching, though. It's also supposed to be a prominent link to the settings. The full scope of the proposed solution is at #10229.

Edit - I can put in some work to make the launching behavior more immediately obvious in this area, I just don't want to lose the toolbar and recordings separation work. It's a pretty confusing part of project settings now.

@clarkus
Copy link
Contributor

clarkus commented Aug 22, 2022

Looked into this more. I think it comes down to how prominent we think launch actions need to be. The core thing we're solving for in #10229 is separating and clarifying how the domains / URLs work. This could still be done in the project settings with separate areas for each set of URLs. Any thoughts on which option we should optimize for?

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this. Having built the thing, I've seen first hand how users struggle to find the toolbar. The name "toolbar" brings very little context, thus users have a hard time linking
the tool to what it does.

I'd bet making the menu item's title dynamic (adding launch) will help users figure out what do you use the toolbar for, or at least make them curious. As it stands now, it feels like this is yet another configuration screen, not the gateway to "that floaty button thing on your page".

I think we should also split up the toolbar and session recording URLs. Issue #10229 is in the list of bugs for this sprint. I moved it higher in the list under "Settings", and added a donut.

@Twixes Twixes merged commit c83571d into master Aug 24, 2022
@Twixes Twixes deleted the launch-toolbar branch August 24, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants