Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip creating a visionOS simulator if not needed #289

Merged
merged 2 commits into from
Jan 29, 2025
+16 −22
Merged

chore: skip creating a visionOS simulator if not needed #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32aa493
chore: skip creating a visionOS simulator if not needed
ioannisj Jan 29, 2025
1519242
fix: external sdk example
ioannisj Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## Next

## 3.19.2 - 2025-01-29

- fix: XCFramework builds failing ([#288](https://github.com/PostHog/posthog-ios/pull/288))
- chore: Session Replay GA ([#286](https://github.com/PostHog/posthog-ios/pull/286))

Expand Down
9 changes: 5 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,12 @@ bootstrap:
brew install peripheryapp/periphery/periphery

# download SDKs and runtimes
# install any simulator(s) missing from runner image
# create Apple Vision Pro simulator if missing
# release pod
releaseCocoaPods:
# I think we can do without these next 2 steps but let's leave it for now
set -o pipefail && xcrun xcodebuild -downloadAllPlatforms
# install Apple Vision Pro
xcrun simctl create "Apple Vision Pro" "Apple Vision Pro" "xros2.2"
@if ! xcrun simctl list devices | grep -q "Apple Vision Pro"; then \
LATEST_RUNTIME=$$(xcrun simctl list runtimes | grep "com.apple.CoreSimulator.SimRuntime.xrOS" | sort -r | head -n 1 | awk '{print $$NF}') && \
xcrun simctl create "Apple Vision Pro" "Apple Vision Pro" "$$LATEST_RUNTIME"; \
fi
pod trunk push PostHog.podspec --allow-warnings
27 changes: 11 additions & 16 deletions PostHogExampleExternalSDK/PostHogExampleExternalSDK.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

/* Begin PBXBuildFile section */
DA5CC5B62D43C54C0060722B /* PostHog in Frameworks */ = {isa = PBXBuildFile; productRef = DA5CC5B52D43C54C0060722B /* PostHog */; };
DA5DBDDB2D43DDEA0077B419 /* PostHog in Frameworks */ = {isa = PBXBuildFile; productRef = DA5DBDDA2D43DDEA0077B419 /* PostHog */; };
DAA5EE002D42761F00D437E0 /* PostHog in Frameworks */ = {isa = PBXBuildFile; productRef = DAA5EDFF2D42761F00D437E0 /* PostHog */; };
DAA5EE662D4376EB00D437E0 /* ExternalSDK.swift in Sources */ = {isa = PBXBuildFile; fileRef = DAA5EE652D4376E600D437E0 /* ExternalSDK.swift */; };
DAEA51302D4A1047007B75AB /* PostHog in Frameworks */ = {isa = PBXBuildFile; productRef = DAEA512F2D4A1047007B75AB /* PostHog */; };
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
Expand Down Expand Up @@ -44,7 +44,7 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
DA5DBDDB2D43DDEA0077B419 /* PostHog in Frameworks */,
DAEA51302D4A1047007B75AB /* PostHog in Frameworks */,
DAA5EE002D42761F00D437E0 /* PostHog in Frameworks */,
DA5CC5B62D43C54C0060722B /* PostHog in Frameworks */,
);
Expand Down Expand Up @@ -103,7 +103,7 @@
packageProductDependencies = (
DAA5EDFF2D42761F00D437E0 /* PostHog */,
DA5CC5B52D43C54C0060722B /* PostHog */,
DA5DBDDA2D43DDEA0077B419 /* PostHog */,
DAEA512F2D4A1047007B75AB /* PostHog */,
);
productName = TestBuildIssues;
productReference = DAA5EDF12D42761400D437E0 /* ExternalSDK.framework */;
Expand Down Expand Up @@ -133,7 +133,7 @@
mainGroup = DAA5EDE72D42761400D437E0;
minimizedProjectReferenceProxies = 1;
packageReferences = (
DA5DBDD92D43DDEA0077B419 /* XCRemoteSwiftPackageReference "posthog-ios" */,
DAEA512E2D4A1047007B75AB /* XCLocalSwiftPackageReference "../../posthog-ios" */,
);
preferredProjectObjectVersion = 77;
productRefGroup = DAA5EDF22D42761400D437E0 /* Products */;
Expand Down Expand Up @@ -392,28 +392,23 @@
};
/* End XCConfigurationList section */

/* Begin XCRemoteSwiftPackageReference section */
DA5DBDD92D43DDEA0077B419 /* XCRemoteSwiftPackageReference "posthog-ios" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/postHog/posthog-ios";
requirement = {
branch = "fix/internal-phlibwebp";
kind = branch;
};
/* Begin XCLocalSwiftPackageReference section */
ioannisj marked this conversation as resolved.
Show resolved Hide resolved
DAEA512E2D4A1047007B75AB /* XCLocalSwiftPackageReference "../../posthog-ios" */ = {
isa = XCLocalSwiftPackageReference;
relativePath = "../../posthog-ios";
};
/* End XCRemoteSwiftPackageReference section */
/* End XCLocalSwiftPackageReference section */

/* Begin XCSwiftPackageProductDependency section */
DA5CC5B52D43C54C0060722B /* PostHog */ = {
isa = XCSwiftPackageProductDependency;
productName = PostHog;
};
DA5DBDDA2D43DDEA0077B419 /* PostHog */ = {
DAA5EDFF2D42761F00D437E0 /* PostHog */ = {
isa = XCSwiftPackageProductDependency;
package = DA5DBDD92D43DDEA0077B419 /* XCRemoteSwiftPackageReference "posthog-ios" */;
productName = PostHog;
};
DAA5EDFF2D42761F00D437E0 /* PostHog */ = {
DAEA512F2D4A1047007B75AB /* PostHog */ = {
isa = XCSwiftPackageProductDependency;
productName = PostHog;
};
Expand Down
Loading