chore: skip creating a visionOS simulator if not needed #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisj
commented
Jan 29, 2025
PostHogExampleExternalSDK/PostHogExampleExternalSDK.xcodeproj/project.pbxproj
Show resolved
Hide resolved
marandaneto
approved these changes
Jan 29, 2025
eakurnikov
pushed a commit
to trustwallet/posthog-ios
that referenced
this pull request
Feb 6, 2025
* chore: skip creating a visionOS simulator if not needed * fix: external sdk example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Previous release failed because a new macos-14 image was released from GH on 20/01/25.
Docs say that VisionOS SDK 2.2 should be available but in reality it's VisionOS SDK 2.3. When releasing CocoaPods, we tried to create a required Apple Vision Pro simulator with xros2.2 which failed.
Let's skip creating a VisionOS simulator if not needed, and if we have to, let's detect latest installed SDK version. Hopefully this will resolve the issue
#skip-changelog
💚 How did you test it?
📝 Checklist