fix: xcframework builds #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably deserves a changelog entry? |
marandaneto
approved these changes
Jan 28, 2025
eakurnikov
pushed a commit
to trustwallet/posthog-ios
that referenced
this pull request
Feb 6, 2025
* fix: xcframework builds * fix: import access level * feat: add sample xcframework project * fix: build examples * chore: update CHANGELOG
ioannisj
added a commit
that referenced
this pull request
Mar 5, 2025
* fix: xcframework builds * fix: import access level * feat: add sample xcframework project * fix: build examples * chore: update CHANGELOG
ioannisj
added a commit
that referenced
this pull request
Mar 5, 2025
* chore: session replay ga (#286) * fix: xcframework builds (#288) * fix: xcframework builds * fix: import access level * feat: add sample xcframework project * fix: build examples * chore: update CHANGELOG * Update version * chore: skip creating a visionOS simulator if not needed (#289) * chore: skip creating a visionOS simulator if not needed * fix: external sdk example * Update version * feat: add survey domain models * Merge branch 'main' into feat/mobile-surveys-merge-main # Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift * fix: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
see: https://posthog.slack.com/archives/C06GCP04DT7/p1737633958220259
The way we were importing
phlibwebpcaused it to be exposed in the .swiftinterface of the PostHog library. This unintended exposure occurred becausephlibwebpwas included as a public dependency (currently default) in code, which made its symbols visible outside of the library. In turn, this became a build issue when building an xcframework since usually frameworks are archived using theBUILD_LIBRARY_FOR_DISTRIBUTION=YESfor module stability.To resolve this, the import of
phlibwebpwas made internal which ensures it does not leak into the public interface of the library.#skip-changelog
💚 How did you test it?
make buildExamples📝 Checklist