Deprecate unneeded meta-headers #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated the following: pcl/common/boost.h, pcl/sample_consensus/boost.h, pcl/octree/boost.h, pcl/recognition/boost, pcl/features/boost, pcl/features/eigen.h, and correspondence_rejection_median_distance.hpp
kunaltyagi
approved these changes
Feb 27, 2021
|
I looked a bit further into the registration module, there are more hpp files that are basically empty: icp_nl.hpp and many of the correspondence_rejection_*.hpp files. I guess we can deprecate them all @kunaltyagi ? It would be nice if there was a deprecation notice like "Please include the needed [eigen/boost] headers directly" where appropriate. |
|
@mvieth I noticed those empty headers as well, I wasn't sure if they needed to be deprecated. We can, if you guys think they should be deprecated. |
|
I would say yes, deprecate them. I don't see a reason why we need these empty headers, which are also unnecessarily included by the .h files. |
Deprecated empty headers and added deprecation notice.
mvieth
reviewed
Mar 4, 2021
mvieth
approved these changes
Mar 7, 2021
larshg
reviewed
Mar 7, 2021
registration/include/pcl/registration/correspondence_rejection_var_trimmed.h
Outdated
Show resolved
Hide resolved
larshg
approved these changes
Mar 8, 2021
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated the following:
pcl/common/boost.h, pcl/sample_consensus/boost.h, pcl/octree/boost.h, pcl/recognition/boost, pcl/features/boost, pcl/features/eigen.h, and correspondence_rejection_median_distance.hpp
This is tied to https://github.com/PointCloudLibrary/pcl/issues/4290