Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unneeded meta-headers #4290

Closed
kunaltyagi opened this issue Jul 25, 2020 · 4 comments · Fixed by #4628
Closed

Deprecate unneeded meta-headers #4290

kunaltyagi opened this issue Jul 25, 2020 · 4 comments · Fixed by #4628
Labels
effort: low Rough estimate of time needed to fix/implement/solve good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue

Comments

@kunaltyagi
Copy link
Member

There's a very strong chance we can now deprecated and remove all headers of the form
module/*/boost.h

Not all, but some, yes. pcl/common/boost.h, pcl/filters/boost.h, and pcl/sample_consensus/boost.h, also pcl/geometry/eigen.h and pcl/surface/eigen.haren't used internally by anyone.

Originally posted by @mvieth in #4289 (comment)
@kunaltyagi kunaltyagi added effort: low Rough estimate of time needed to fix/implement/solve good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue labels Jul 25, 2020
@JStech JStech mentioned this issue Aug 30, 2020
Merged
@rabaho
Copy link
Contributor

rabaho commented Feb 26, 2021

I'll take care of this.

@mvieth
Copy link
Member

mvieth commented Feb 26, 2021

That's great!
pcl/filters/boost.h, pcl/geometry/eigen.h, and pcl/surface/eigen.h have already been deprecated by the linked pull request.
pcl/common/boost.h, pcl/sample_consensus/boost.h, pcl/octree/boost.h, and pcl/recognition/boost.h can be deprecated.
pcl/features/boost.h and pcl/features/eigen.h are still used internally, but can be deprecated if you replace their uses with their respective contents.
Slightly different matter, but while you are at it: correspondence_rejection_median_distance.hpp is empty and can also be deprecated, if you remove the include in the .h file.

@rabaho
Copy link
Contributor

rabaho commented Feb 27, 2021

What version should they be deprecated in? 1.15?

@mvieth
Copy link
Member

mvieth commented Feb 27, 2021

What version should they be deprecated in? 1.15?

Yes

@kunaltyagi kunaltyagi linked a pull request Feb 27, 2021 that will close this issue
Deprecate unneeded meta-headers #4628
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Rough estimate of time needed to fix/implement/solve good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate unneeded meta-headers rabaho/pcl
3 participants
@rabaho @kunaltyagi @mvieth