Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

579 Fix dataformatlib.php No such file or dir #587

Merged
merged 1 commit into from
Aug 28, 2024
Merged

579 Fix dataformatlib.php No such file or dir #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions report.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,6 @@

case 'dfs':
require_capability('mod/questionnaire:downloadresponses', $context);
require_once($CFG->dirroot . '/lib/dataformatlib.php');
// Use the questionnaire name as the file name. Clean it and change any non-filename characters to '_'.
$name = clean_param($questionnaire->name, PARAM_FILE);
$name = preg_replace("/[^A-Z0-9]+/i", "_", trim($name));
Expand All @@ -507,12 +506,7 @@
// Check if email report was selected.
$emailreport = optional_param('emailreport', '', PARAM_ALPHA);
if (empty($emailreport)) {
// In 3.9 forward, download_as_dataformat is replaced by \core\dataformat::download_data.
if (method_exists('\\core\\dataformat', 'download_data')) {
\core\dataformat::download_data($name, $dataformat, $columns, $output);
} else {
download_as_dataformat($name, $dataformat, $columns, $output);
}
\core\dataformat::download_data($name, $dataformat, $columns, $output);
} else {
// Emailreport button selected.
if (get_config('questionnaire', 'allowemailreporting') && (!empty($emailroles) || !empty($emailextra))) {
Expand Down
47 changes: 47 additions & 0 deletions tests/behat/download_responses.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
@mod @mod_questionnaire
Feature: Questionnaire responses can be downloaded as a CSV, etc.

Background:
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@example.com |
| student1 | Student | 1 | student1@example.com |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
And the following "course enrolments" exist:
| user | course | role |
| teacher1 | C1 | editingteacher |
| student1 | C1 | student |
And the following "activities" exist:
| activity | name | introduction | course | idnumber |
| questionnaire | Test questionnaire download | Test questionnaire description | C1 | questionnaire1 |
And I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "Test questionnaire download"
And I navigate to "Questions" in current page administration
And I add a "Text Box" question and I fill the form with:
| Question Name | Q1 |
| No | n |
| Input box length | 10 |
| Max. text length | 15 |
| Question Text | Enter some text |
And I log out
And I log in as "student1"
And I am on "Course 1" course homepage
And I follow "Test questionnaire download"
And I navigate to "Answer the questions..." in current page administration
And I set the field "Enter some text" to "Student response"
And I press "Submit questionnaire"
And I log out

@javascript
Scenario: Download responses
Given I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "Test questionnaire download"
And I navigate to "View all responses" in current page administration
Then I click on "Download" "link"
# Without the ability to check the downloaded file, the absence of an
# exception being thrown here is considered a success.
And I click on "Download" "button"
Loading