579 Fix dataformatlib.php No such file or dir #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchurchward
requested changes
Aug 21, 2024
db66939 to
5b41a80
Compare
|
Rebased. |
6253d1a to
3309603
Compare
|
Your PR still includes commits from other changes than this one. The PR needs to just include the commit(s) for this PR. |
Remove require_once() for a core file removed in Moodle 4.4 (MDL-80409). This plugin requires Moodle 4.1 and so instead can use the replacement introduced in Moodle 3.9, dataformat::download_data().
5b41a80 to
1ea3727
Compare
|
I've tried rebasing this again, I can only see my commit now. Please let me know if there are still issues with this. |
mchurchward
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove require_once() for a core file removed in Moodle 4.4 (MDL-80409). This plugin requires Moodle 4.1 and so instead can use the replacement introduced in Moodle 3.9, dataformat::download_data().
Proposed fix for #579