developer mode fixes and cleanups #203
Conversation
The library directory needs to be checked after arguments are parsed,
since -developer can affect it.
If we are in developer mode, we need to explicitly pick a place to
extract tables. There are three obvious choices. See code.
Look in ${gToolPath} for downloaded zips, since that's where a git
clone/full download puts them.
Only delete zip files if we downloaded them. This keeps git from being
annoyed at missing zip files.
|
Yes. I should have moved _checkLibraryDirectory but forgot to do it. Thank you for catching this error. And ACPI it is. I already made the changes in my local tree and I will commit it after I some test runs. But I don't think that we have to change ${gPath} into ${gToolPath} because this are two different directories, and we don't (try to) remove the ZIP file from the tools directory. All in all good changes, but now freqVectorsEdit.sh is broken, since the script also need to know where the configuration files are. I guess that we could add a preference for it, and if the preference isn't there, and the old ~/Library/ssdtPRGen path is unusable... then we have to download the configuration files. Edit: ssdtPRGen.sh v18.2 committed. Please note that we need to verify the -develop, -extract and -custom arguments (in the mix). |
|
OK, I will test. |
|
I wish that GitHub would notify me by email when a message has been edited. I missed this earlier. I will look at freqVectorsEdit.sh too, which I have been meaning to test/use again. |
|
Whoops, i submitted duplicate issues here before reading this 😹 |
The library directory needs to be checked after arguments are parsed, since
-developercan affect it.If we are in developer mode, we need to explicitly pick a place to extract tables. There are three obvious choices. See code.
Look in
${gToolPath}for downloaded zips, since that's where a git clone/full download should put them.Only delete zip files if we downloaded them. This keeps git from being annoyed at missing zip files.
Tested as
-developer(traditional behavior)-developer(shiny clean directory :–)