Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

408 exit relapse dialog #144

Merged
merged 5 commits into from
Aug 4, 2023
Merged

408 exit relapse dialog #144

merged 5 commits into from
Aug 4, 2023

Conversation

wbaccinelli
Copy link
Contributor

Fixes PerfectFit-project/virtual-coach-issues#408
Fixes PerfectFit-project/testing-tickets#53

  • Moved possibility to leave the dialog in the first question.
  • Added current_intervention_component slot setting for correctly marking the dialog completion.
  • Added a final sentence in case the user leaves the dialog in the first question.

@wbaccinelli wbaccinelli requested a review from bscheltinga August 3, 2023 13:36
bscheltinga
bscheltinga approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@bscheltinga bscheltinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good :)

Rasa_Bot/data/rules/rules_relapse_dialog.yml Show resolved Hide resolved
Rasa_Bot/domain/domain_relapse_dialogs.yml Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wbaccinelli wbaccinelli merged commit 6122b08 into main Aug 4, 2023
@nelealbers nelealbers mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bscheltinga bscheltinga bscheltinga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect message about non-response HRS dialog - move possibility to stop at the beginning
2 participants
@wbaccinelli @bscheltinga