Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spray can double menu #27944

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Jan 11, 2025

What Does This PR Do

Fixes #27772
Registers a signal on the spray cans New(), preventing it from opening the crayon menu.

Why It's Good For The Game

Double menu is confusing

Testing

Checked crayon menu
Checked spraycan menu
Freshly spawned crayons do random letters, runes and grafitti
Freshly spawned random crayons are in random colors


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
Fix: Spray can no longer opens 2 menus
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 11, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 18, 2025
@Burzah Burzah added the Fix This PR will fix an issue in the game label Jan 22, 2025
@Burzah Burzah added this pull request to the merge queue Jan 22, 2025
Merged via the queue into ParadiseSS13:master with commit f748079 Jan 22, 2025
17 checks passed
@Toastical Toastical deleted the spraycan-double-menu branch January 22, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a spraypaint can inhand will always open the change pattern window
4 participants