Create interaction test harness. #27643
Merged
+123
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
requested changes
Dec 14, 2024
lewcc
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Looks pretty good to me, I just figured I'd drop some notes.
One thing I thought of while looking through this is that we already do have something kind of similar in the realm of deadchat control. I don't know if there would be any interest in expanding upon/somehow integrating that kind of framework?
Contrabang
approved these changes
Dec 22, 2024
Burzah
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR implements the skeleton of a new testing harness designed for verifying behavior between multiple objects in scenarios relatively close to in-round behavior. You can see with the sample attack chain-related test that the API is somewhat readable, allowing you to take control of a mob, give it a fake mind, spawn things on it/near it, and have it interact with those things. The goal is to have a slightly cleaner level of abstraction over the actual code performing the actions and provide useful helpers for checking the state of things.
This will probably run into some walls when it comes to mind fidelity but we'll burn that bridge when we get to it.
Why It's Good For The Game
Better tests?
Testing
Wrote em
Declaration
Changelog
NPFC