Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password show/hide symlinks for Plasma 6 #3677

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Add password show/hide symlinks for Plasma 6 #3677

merged 2 commits into from
Mar 27, 2024

Conversation

swomf
Copy link
Contributor

@swomf swomf commented Mar 26, 2024

Plasma 6 relies on icons named password-show-off and password-show-on for the password visibility button. This commit adds symlinks for each that point to hint.svg and visibility.svg respectively.

Fixes #3671.

Demonstration (kscreenlocker)

Before:

password hidden

image

password shown

image

After:

password hidden

image

password shown

image

@SmartFinn
Copy link
Member

Thanks. The symlinks have to use relative path to targets instead of absolute. Could you fix it? Please run the following commands inside the cloned repo on your machine:

cd tools/work/
./new-symlink.sh actions hint.svg password-show-off.svg
./new-symlink.sh actions view-hidden.svg password-show-on.svg
./convert.sh
./put-into-theme.sh
git add -u
git commit -m "Fix password-show-on and password-show-off symlinks"
git push

I can't change this PR because you didn't create a separated branch for it.

@SmartFinn SmartFinn merged commit 68e74d4 into PapirusDevelopmentTeam:master Mar 27, 2024
1 check passed
enzoritto pushed a commit to enzoritto/papirus-icon-theme that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Show password button has the same icon on both hide and show state on plasma 6
2 participants