Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Fall Guys #3539

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

morganist
Copy link
Member

closes #3277
I finished this because the icon is really cute and I hated seeing it rot in an open pull request

fall-guys@64x64 fall-guys@48x48 fall-guys@32x32 fall-guys@24x24 fall-guys@16x16

@SmartFinn
Copy link
Member

SmartFinn commented Aug 29, 2023

Thanks! I also wanted to finish the icon.

There is a bug with 48px that you missed. This SVG file has viewBox attribute that set wrong scaling. The scaling should be equal to 1.

image

And the light outline on dark objects should be 10, not 20.

@morganist
Copy link
Member Author

There is a bug with 48px that you missed. This SVG file has viewBox attribute that set wrong scaling. The scaling should be equal to 1.

Inkscape really does things I can't comprehend sometimes...

@morganist
Copy link
Member Author

but i love it, of course

@SmartFinn
Copy link
Member

@morganist

minor fixes for fall guys

* and added new bugs 😆

Don't worry, I already fix them.

@SmartFinn SmartFinn merged commit ab1687f into PapirusDevelopmentTeam:master Aug 29, 2023
@hugeblank
Copy link

Nice! I did not have the skills or drive to continue working on my PR given how badly I biffed it the first time around. Thanks for doing this!

@morganist morganist deleted the fallguys branch August 29, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants