Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Fall Guys #3277

Closed
wants to merge 1 commit into from

Conversation

hugeblank
Copy link

and add symlinks for the respective lutris and steam icon ids.

closes #2359
closes #2358
They were already closed, but this PR makes it conclusive.

and add symlinks for the respective lutris and steam icon ids.

closes PapirusDevelopmentTeam#2359
closes PapirusDevelopmentTeam#2358
@varlesh
Copy link
Contributor

varlesh commented Sep 1, 2022

Your icons have errors

  • we not use millimeters for size, need change to pixels
  • background layer not have shadow and stroke
  • we use pixel perfect align
  • icon not clean (use prepare.sh)

Example 48px icon:

<svg xmlns="http://www.w3.org/2000/svg" width="48" height="48" version="1.1" viewBox="0 0 12.7 12.7">
 <path style="opacity:0.2" d="M 6.3499999,1.3229168 A 5.2916663,5.2916663 0 0 0 1.0583333,6.6145834 v 4.2333336 c 0,0.586316 0.4720167,1.058333 1.0583333,1.058333 h 4.2333333 4.2333331 c 0.586317,0 1.058334,-0.472017 1.058334,-1.058333 V 6.6145834 A 5.2916663,5.2916663 0 0 0 6.3499999,1.3229168 Z"/>
 <circle style="fill:#248afd" cx="6.35" cy="6.35" r="5.292"/>
 <circle style="fill:#e4e4e4" cx="6.35" cy="6.35" r="3.704"/>
 <path style="fill:#248afd" transform="scale(0.26458333)" d="M 4 24 L 4 40 C 4 42.216 5.7840001 44 8 44 L 40 44 C 42.216 44 44 42.216 44 40 L 44 24 L 4 24 z"/>
 <path style="opacity:0.2" d="M 10.054167,6.6145838 A 3.7041666,3.7041666 0 0 1 6.35,10.31875 3.7041666,3.7041666 0 0 1 2.6458334,6.6145838 3.7041666,3.7041666 0 0 1 6.35,2.9104174 3.7041666,3.7041666 0 0 1 10.054167,6.6145838 Z"/>
 <path style="fill:#ffffff" d="M 10.054167,6.3499998 A 3.7041666,3.7041666 0 0 1 6.35,10.054166 3.7041666,3.7041666 0 0 1 2.6458334,6.3499998 3.7041666,3.7041666 0 0 1 6.35,2.6458334 3.7041666,3.7041666 0 0 1 10.054167,6.3499998 Z"/>
 <ellipse style="fill:#4f4f4f" cx="4.895" cy="6.35" rx=".661" ry=".529"/>
 <ellipse style="fill:#4f4f4f" cx="4.895" cy="7.649" rx=".661" ry=".553"/>
 <rect style="fill:#4f4f4f" width="1.323" height="1.323" x="4.23" y="6.35"/>
 <ellipse style="fill:#4f4f4f" cx="7.805" cy="6.35" rx=".661" ry=".529"/>
 <ellipse style="fill:#4f4f4f" cx="7.805" cy="7.649" rx=".661" ry=".553"/>
 <rect style="fill:#4f4f4f" width="1.323" height="1.323" x="7.14" y="6.35"/>
 <path style="opacity:0.2;fill:#ffffff" transform="scale(0.26458333)" d="M 24 4 A 19.999999 19.999999 0 0 0 4 24 A 19.999999 19.999999 0 0 0 4.0195312 24.5 A 19.999999 19.999999 0 0 1 24 5 A 19.999999 19.999999 0 0 1 43.988281 24.328125 A 19.999999 19.999999 0 0 0 44 24 A 19.999999 19.999999 0 0 0 24 4 z"/>
</svg>

preview:
image

@hugeblank
Copy link
Author

had a feeling they weren't perfect. this is my first time doing this. Will fix.

@varlesh
Copy link
Contributor

varlesh commented Sep 1, 2022

had a feeling they weren't perfect. this is my first time doing this. Will fix.

Please use templates from tools/work/Papirus/apps/

Read this info
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/tree/master/tools/work#readme
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/tools/work/examples-papirus.svg

@hugeblank
Copy link
Author

hugeblank commented Sep 1, 2022

Read this info https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/tree/master/tools/work#readme https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/tools/work/examples-papirus.svg

I saw both of these, it's where I got the colors for each element of the body (eye, faceplate, body). Wasn't sure to what extreme the format was to be followed. Now I know.

Is it alright if I just resize the icon you provided? If it follows the style rules then it's pretty much exactly what I'd want.

@varlesh
Copy link
Contributor

varlesh commented Sep 1, 2022

Is it alright if I just resize the icon you provided? If it follows the style rules then it's pretty much exactly what I'd want.

Yes, it's already 48px icon. But do not forget about pixel align (shift+3 on inkscape) and 16px icon not used shadow and stroke

@hugeblank
Copy link
Author

Yes, it's already 48px icon. But do not forget about pixel align (shift+3 on inkscape) and 16px icon not used shadow and stroke

Just to make sure I understand, you're saying in this that these 3 strokes are removed on the 16px icon?
image

@varlesh
Copy link
Contributor

varlesh commented Sep 1, 2022

Just to make sure I understand, you're saying in this that these 3 strokes are removed on the 16px icon?

Yes, see templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon request] Fall Guys [Icon request] Fall Guys
2 participants