Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDFsam not using icon theme #3619

Closed
Elaborendum opened this issue Dec 9, 2023 · 0 comments
Closed

PDFsam not using icon theme #3619

Elaborendum opened this issue Dec 9, 2023 · 0 comments
Labels
completed enhancement

Comments

@Elaborendum
Copy link

  • Distribution (version): Ubuntu 22.04
  • Desktop environment: GNOME
  • Installing method: PPA
  • App name (version): PDFsam

I installed PDFsam through Ubuntu's repository, and it's recognized as just "pdfsam" (despite being PDFsam Basic) The icon attribute in its desktop file is "pdfsam". I've ran the hardcoded fixer script, but it didn't change it. But I checked here and Papirus seems to have an icon pointing to "pdfsam-basic" but not for just "pdfsam".
SmartFinn added a commit that referenced this issue Dec 9, 2023
@SmartFinn
Rename pdfsam-basic to pdfsam #3619
553827c 
The official DEB package still contains the hardcoded icon #1168, but
the Debian and Ubuntu packages do not.
Also the hardcode-fixer changes the icon name to pdfsam, not pdfsam-basic.
See
https://github.com/Foggalong/hardcode-fixer/blob/ba5d874fff1aa09f7bafed29bf49d3ce586fb922/tofix.csv#L312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SmartFinn @Elaborendum