Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFsam Basic Icon Request #1168

Closed
KarthikRoy opened this issue Mar 8, 2018 · 7 comments
Closed

PDFsam Basic Icon Request #1168

KarthikRoy opened this issue Mar 8, 2018 · 7 comments

Comments

@KarthikRoy
Copy link

Application name: PDFsam Basic
Icon name: PDFsam Basic
Original icon image:
pdfsam basic
Link to official page: https://pdfsam.org/download-pdfsam-basic/

@varlesh
Copy link
Contributor

varlesh commented Mar 9, 2018

@KarthikRoy wrong icon name

@KarthikRoy
Copy link
Author

I am so sorry for my mistake, I am only learning how to do things on my own in Linux. Could you please tell me how I can find the correct icon name? I use Ubuntu GNOME 16.04. What I did before was to go to /usr/share/applications and typed the name I saw there. A screen-shot is attached of that folder with the application. I think I should have looked for some other folder because this was an application and not an icon folder. Also, for the original icon image, I did an internet search and found the image that I had uploaded.
in applications

@varlesh
Copy link
Contributor

varlesh commented Mar 9, 2018

@KarthikRoy Drop PDFsam Basic launcher to gedit window ( or other text editor) and
See line icon=

@KarthikRoy
Copy link
Author

Thank you for your help. I have got the following when I dropped the launched into a text editor. I think icon name is pdfsam-basic
[Desktop Entry]
Version=1.0
Type=Application
Encoding=UTF-8
Name=PDFsam Basic
Comment=Open source desktop application to split, merge, rotate and mix PDF files
Exec=/opt/pdfsam-basic/bin/pdfsam-basic %F
Path=/opt/pdfsam-basic/
Icon=/opt/pdfsam-basic/icon.svg
MimeType=application/pdf
Terminal=false
Categories=Office;

@varlesh
Copy link
Contributor

varlesh commented Mar 9, 2018

I think icon name is pdfsam-basic

No, it's icon hardcoded, because have full path to icon. See for more info:
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme#hardcoded-icons

@KarthikRoy
Copy link
Author

Thank you for your help

varlesh added a commit that referenced this issue Mar 9, 2018
@varlesh
Copy link
Contributor

varlesh commented Mar 9, 2018

@KarthikRoy Icon added, update from git and change icon name to:
Icon=pdfsam-basic

@varlesh varlesh closed this as completed Mar 9, 2018
SmartFinn added a commit that referenced this issue Dec 9, 2023
The official DEB package still contains the hardcoded icon #1168, but
the Debian and Ubuntu packages do not.
Also the hardcode-fixer changes the icon name to pdfsam, not pdfsam-basic.
See
https://github.com/Foggalong/hardcode-fixer/blob/ba5d874fff1aa09f7bafed29bf49d3ce586fb922/tofix.csv#L312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants