Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get iris ready with upstream #3

Open
wants to merge 1 commit into
base: rebase_v2
Choose a base branch
from

Conversation

ffurrer
Copy link

@ffurrer ffurrer commented Jul 8, 2015

I quickly got iris running, by these adjustments... so probably similar ones have to be made for ardrone and vtol, it would be nice if you could just get all your launch files running

@@ -75,8 +73,6 @@
motor_number="0"
rotor_drag_coefficient="${rotor_drag_coefficient}"
rolling_moment_coefficient="${rolling_moment_coefficient}"
mesh="iris_prop"
mesh_scale="${mesh_scale_prop}"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want your own props, which I would appreciate, then we should add this parameter to the vertical_rotor macro. I guess you had it in there at some point :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be great.

@LorenzMeier
Copy link
Member

Thanks for this! I'll re-do the models using this pattern and send a much smaller PR against upstream.

@LorenzMeier
Copy link
Member

@ffurrer How open would you be to completely factor out the ROS interface in rotors (as its own plugin)? The reason I ask is that the ROS dependency is quite heavy for us (e.g. on Mac OS or Windows) and the Gazebo Protobuf API would fix that issue for us:
http://gazebosim.org/tutorials?tut=custom_messages

This is similar in spirit as it adds the MAVLink interface as a plugin:
https://github.com/PX4/rotors_simulator/pull/4/files

We're messing with other simulators right now for other platforms, and I'd like to converge on Gazebo. Also the runtime performance is a bit of a concern, since we need to run much faster than realtime - maybe detach front and backend and only render every 10th iteration?

@markusachtelik
Copy link

I see the point -- we however don't have the resources to do this right now, but we'd be happy to accept PRs ;). I would like to avoid protobuf to ros conversion nodes and would thus favor conditional compilation and detect whether ros is available or not. We probably best discuss this while having a coffee, I have a few ideas on this.

@gbmhunter gbmhunter deleted the PX4-rebase_v2 branch February 16, 2017 15:12
devbharat pushed a commit to devbharat/rotors_simulator that referenced this pull request Mar 19, 2017
Implemented changes as recommended by ASL in preparation for pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants