Remove illuminate/database dependency #59
Conversation
|
As you can see, there are some errors suporting lowest versions of Laravel 6.x on PHP 7.4. We need to decide, either we update minimal Laravel 6.x version, or we fix these bugs |
|
This MR is now on pause, until #58 is merged and we decide what to do about my previous comment, after which I will rebase onto latest development branch and we will also test it on PHP 8.1 |
|
I've investigated, and found out, that these errors are occur, because |
|
I've fixed all errors. If you're not agreed to given solution, let me know, and I'll revert it |
|
@eschricker done and dusted! |
.github/workflows/phpunit.yml
Outdated
| - name: Set Minimum Laravel ${{ matrix.laravel }} Versions | ||
| run: | | ||
| composer require "illuminate/contracts:${{ matrix.laravel }}" --no-interaction --no-progress --no-update | ||
| composer require "vlucas/phpdotenv:${{ matrix.dotenv }}" --no-interaction --no-progress --no-update |
There was a problem hiding this comment.
if you would add --dev here we would eliminate one warning (vlucas/phpdotenv is currently present in the require-dev key and you ran the command without the --dev flag, which would move it to the require key.)
There was a problem hiding this comment.
@eschricker I added it for us.
There was a problem hiding this comment.
The --dev is just needed on phpdotenv not on illuminate/contracts
There was a problem hiding this comment.
The
--devis just needed on phpdotenv not on illuminate/contracts
Ok, I already remove it from contracts. You're welcome to close the PR if this is was missing :)
This MR closes #55