Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted and very strict dependency illuminate/database #55

Closed
leon0399 opened this issue Nov 20, 2021 · 1 comment · Fixed by #59
Closed

Unwanted and very strict dependency illuminate/database #55

leon0399 opened this issue Nov 20, 2021 · 1 comment · Fixed by #59

Comments

@leon0399
Copy link
Member

Subject of the issue

Describe your issue here.

Your environment

Q A
Bug? yes
New Feature? no
Framework Laravel / Lumen
Framework version any
Package version 1.2.y
PHP version 7.2+

Information

composer.json has an unneccesary dependency of illuminate/database with very strict version rules (only latest versions of egacy Laravel versions). According to my tests, whis dependency is not required in project root, because it not directly used from this package
@leon0399 leon0399 mentioned this issue Nov 20, 2021
Merged
@eschricker
Copy link
Contributor

The very strict dependency was added due to dependabot security alerts. But when the dependency is not used, I totally agree to remove it

@Geoffry304 Geoffry304 mentioned this issue May 31, 2022
Closed
@maxdiable maxdiable mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove illuminate/database dependency
2 participants
@leon0399 @eschricker