Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
The hack was recently broken on master. We could fix it, but it's sort of pointless. Additionally, #3549 will break it as it forces the window to close when the renderer switches. This is desired as sharing a surface between different renderers is bad behavior.
At it's best, it offered a users a way to work around that some FMVs are not properly displayed by the HW renderer due to limitations of the cache by automatically switching to the more compatible sw renderer when they played.
At it's worst, it's a threading nightmare that barely worked and was never going to be a long term solution especially seeing as it conflicts with future changes that we would like to make.
Instead, I'll purge it and we'll work on making the HW renderer better instead of relying on a hack. Games which require sw mode will be tracked here: #3805
close: #3804