Greg/vsync #1950

gregory38 · 2017-05-21T21:52:12Z

To be discussed because OpenGL tearing/compositor/vsync is a nightmare.

Related to issue #1437

mirh · 2017-05-21T22:14:32Z

Seriously, it's just about nvidia driver giving us problems.
I'm not saying we should flip the bird (I already posted on their dev forums, hoping they can clarify.. just anything)...
but in the meantime for as much I know, you might as well rollout the perfect implementation in the ideal® world (what I think you/I/we had already in mind), plus only:

just wait to reintroduce WS_POPUP
to the DwmIsCompositionEnabled && window!=monitor check, add && vendorId==nvidia

tabnk · 2017-05-22T04:54:56Z

Interesting :). Going to test soon ...

tabnk · 2017-05-22T05:17:39Z

illegal else without matching if

D:\torrent\pcsx2\plugins\GSdx\GSWndWGL.cpp 332

void GSWndWGL::SetVSync(int vsync)
{
m_vsync = vsync;
// m_swapinterval uses an integer as parameter
// 0 -> disable vsync
// n -> wait n frame
else if (m_swapinterval && vsync != 0x10000) m_swapinterval(vsync);
}

tabnk · 2017-05-22T08:29:36Z

Tested on Windows 10 with Nvidia GPU. Full screen and GDSX in OpenGL. Nvidia vsync setting handle by pcsx2.

Disabled: No tearing but frame pacing.
Adaptive: No tearing and no frame pacing.
Windows Compositor: No tearing but minor/some frame pacing.

Btw, both adaptive and Windows compositor increase input lag

mirh · 2017-05-22T09:20:21Z

Windows Compositor: No tearing but minor/some frame pacing.

Isn't that the same of what was reportedly perfect?

Btw, both adaptive and Windows compositor increase input lag

Mhhh, so my paranoia in #1941 wasn't totally tinfoil 😝
http://mojolabs.nz/posts.php?topic=94676#1088686
Might this make some sense?

EDIT: btw, how do you measure input lag? Just guesswork?

tabnk · 2017-05-22T15:29:58Z

Game like GT4 with input lag will be easily noticeable.

ssakash

Haven't tested the code yet, just some minor reviews based on a brief look at the code.

pcsx2/Pcsx2Config.cpp

+		default: return 0;
+	}
+
+	return 0;


pcsx2/gui/Panels/GSWindowPanel.cpp

 	m_check_DclickFullscreen = new pxCheckBox( this, _("Double-click toggles fullscreen mode") );
 	m_check_AspectRatioSwitch = new pxCheckBox(this, _("Switch to 4:3 aspect ratio when an FMV plays"));
 	//m_check_ExclusiveFS = new pxCheckBox( this, _("Use exclusive fullscreen mode (if available)") );

 	m_text_Zoom->SetToolTip( pxEt( L"Zoom = 100: Fit the entire image to the window without any cropping.\nAbove/Below 100: Zoom In/Out\n0: Automatic-Zoom-In untill the black-bars are gone (Aspect ratio is kept, some of the image goes out of screen).\n  NOTE: Some games draw their own black-bars, which will not be removed with '0'.\n\nKeyboard: CTRL + NUMPAD-PLUS: Zoom-In, CTRL + NUMPAD-MINUS: Zoom-Out, CTRL + NUMPAD-*: Toggle 100/0"
 	) );

-	m_check_VsyncEnable->SetToolTip( pxEt( L"Vsync eliminates screen tearing but typically has a big performance hit. It usually only applies to fullscreen mode, and may not work with all GS plugins."
+	m_combo_vsync->SetToolTip( pxEt( L"Vsync eliminates screen tearing but typically has a big performance hit. It usually only applies to fullscreen mode, and may not work with all GS plugins."


plugins/GSdx/GS.cpp

@@ -967,7 +965,7 @@ EXPORT_C GSsetFrameSkip(int frameskip)

 EXPORT_C GSsetVsync(int enabled)
 {
-	s_vsync = !!enabled;
+	s_vsync = enabled;


pcsx2/Pcsx2Config.cpp

+		return 0;
+
+	if (g_LimiterMode == Limit_Turbo)
+		return 0;


gregory38 · 2017-05-25T09:05:33Z

https://github.com/PCSX2/pcsx2/blob/master/pcsx2/gui/FrameForGS.cpp#L494

This function uses an extra parameter for flags. Technically it ought to be wx flags but I think MS flags will be forwarded.

gregory38 · 2017-05-29T09:27:09Z

@tabnk
I added the hidden option EnableVsyncWindowFlag that must be equivalent to WS_POPUP. Could you test if it is working as expecting.

tabnk · 2017-05-29T14:37:46Z

For this build, whether EnableVsyncWindowFlag disabled or enabled cannot go full screen.

gregory38 · 2017-05-30T12:17:14Z

@tabnk I fixed my code. Could you retry it thanks you.

tabnk · 2017-05-30T13:00:39Z

With EnableVsyncWindowFlag=enabled at PCSX2_ui.ini. Nvidia setting handle by pcsx2.

vsync disabled: No tearing but frame pacing
vsync standard: No tearing but frame pacing
vsync adaptive: No tearing but less frame pacing
vsync window compositor: No tearing but little frame pacing

Edit by greg with previous result without EnableVsyncWindowFlag

Tested on Windows 10 with Nvidia GPU. Full screen and GDSX in OpenGL. Nvidia vsync setting handle by pcsx2.

Disabled: No tearing but frame pacing.
Adaptive: No tearing and no frame pacing.
Windows Compositor: No tearing but minor/some frame pacing.

Btw, both adaptive and Windows compositor increase input lag

mirh · 2017-05-30T13:02:10Z

Coooooould you test <381 drivers?

tabnk · 2017-05-30T13:09:16Z

Can't tested in driver 381 below. Already customise per game setting on Nvidia control panel so if install old driver than all my setting will deleted.

gregory38 · 2017-05-30T13:17:41Z

@tabnk
Do you feel that new option have any impact ? In the end what is the best configuration ?

tabnk · 2017-05-30T13:26:07Z

Actually I'm felt almost no different whether EnableVsyncWindowFlag is enabled or disabled.

Depends on individual preference, both Adaptive and Windows Compositor are good.

mirh · 2017-05-30T13:26:45Z

https://forums.geforce.com/default/topic/914268/export-import-nvidia-control-panel-settings-and-color-profiles/#4796732
Also, last time I checked settings were kept unless checking "clean install" option.

gregory38 · 2017-05-30T13:34:32Z

Well I'm not sure the flag propagate well to the windows API. Need a windows dev to confirm it.

tabnk · 2017-05-30T13:46:10Z

Comparing to this

pcsx2/3rdparty/wxwidgets3.0/src/msw/toplevel.cpp

Line 1114 in d8e0b9f

// newStyle |= WS_POPUP;

and your new code.

In full screen mode and disable all vsync, earlier one got tearing but your no tearing. Maybe your doesn't propagate well.

gregory38 · 2017-05-30T14:23:06Z

New version that should propagate the flag.

tabnk · 2017-06-01T12:37:31Z

On new version, screen tearing work on full screen.

mirh · 2017-06-01T12:43:27Z

Does any of the v-sync options fix it then?

tabnk · 2017-06-01T12:51:40Z

With tearing enable on full screen.

vsync disabled: Tearing and frame pacing
vsync standard: Tearing and some frame pacing
vsync adaptive: No tearing and no noticeable frame pacing. Very good for my GT4.
vsync window compositor: Tearing but maybe some frame pacing

gregory38 · 2017-06-12T19:40:13Z

So, I don't know exactly what to do. Here my current proposal

Keep the combo box but with 3 states (OFF / ON / adaptive). Please share you opinion on the name. Adaptive is also called "Late Vsync". Therefore keep integer setup on GS side. I need to add a fallback for drivers that don't support it.
I removed Vsync from the preset as "Late vsync" should be better but it isn't supported by all drivers. Opinion is welcome.
Keep the hidden WS_POPUP option
Drop vsync window compositor (or at least don't merge it until we understand fully the behavior and potentially auto detect the fullscreen mode).

mirh · 2017-06-12T20:06:31Z

Drivers that don't support adaptive should just not have it presented/available, I guess.
For the remainder, I'm fine.
(assuming this DwmIsCompositionEnabled && window!=monitor check gets added)
Then, nvidia users can even screw for all that I care, considering I have been asking about trying previous drivers and nobody seems to listen.

gregory38 · 2017-06-13T07:11:20Z

Drivers that don't support adaptive should just not have it presented/available, I guess.

The thing is that you know about the support when you call the GL swap interval function. And the option is on the core side. Instead we could just fallback to vsync.

 (assuming this DwmIsCompositionEnabled && window!=monitor check gets added)

I propose that we merge the others parts. And then we try to find how to write stuff for DWM.

mirh · 2017-06-13T09:52:25Z

The thing is that you know about the support when you call the GL swap interval function. And the option is on the core side. Instead we could just fallback to vsync.

Oh right. Then I guess whatever you said make sense.

I propose that we merge the others parts. And then we try to find how to write stuff for DWM.

Again, I don't think the problem is dwm, and that's also simply what's already used by glfw guys too.
Besides, wasn't all this fuss basically only about the discovery of dwmflush?

We have now 4 states * no * on * Compositor handle : DWM on windows/GL * Dynamic/adaptative : Could be nice tradeoff between perf and quality So far only the first 2 are implemented in the GS plugin Dynamic will use the value -1 as it is a direct mapping of the GL api. Compositor will use the flag 0x10000 Note: potentially the tooltip can be improved v2: use || instead of multiple if

So far the implementation is really basic but it is enough for testing

gregory38 · 2017-07-03T17:23:59Z

Note: I pushed a rebased version. So only the important bits remain.

lightningterror · 2017-07-04T21:31:39Z

Can this be closed since there is a new improved PR ?

gregory38 · 2017-07-10T12:41:38Z

Yes let's close it.

gregory38 added Enhancement / Feature Request GS: OpenGL labels May 21, 2017

gregory38 force-pushed the greg/vsync branch 2 times, most recently from a428dd2 to f465e9e Compare May 22, 2017 07:20

ssakash reviewed May 22, 2017

View reviewed changes

turtleli added the Changes translatable strings label May 23, 2017

gregory38 added the WIP label May 24, 2017

gregory38 mentioned this pull request Jun 12, 2017

Bug/Feature request: Disable vsync temporarily while frame limiting is disabled #1971

Closed

gregory38 force-pushed the greg/vsync branch from e583349 to 84c0ca6 Compare June 12, 2017 19:09

gregory38 added 2 commits July 3, 2017 19:22

gsdx: add DWMFlush support

1063233

So far the implementation is really basic but it is enough for testing

gregory38 force-pushed the greg/vsync branch from 84c0ca6 to 1063233 Compare July 3, 2017 17:22

mirh mentioned this pull request Jul 3, 2017

Stuttering in all games in GIT builds (HW and SW affected) #1437

Closed

gregory38 mentioned this pull request Jul 4, 2017

Greg/vsync take2 #2000

Merged

ssakash mentioned this pull request Jul 5, 2017

PCSX2-WX: Add restore defaults button to GS panel #2003

Merged

gregory38 closed this Jul 10, 2017

mirh mentioned this pull request Sep 1, 2017

Get WS_POPUP back #2058

Closed

MrCK1 mentioned this pull request Feb 12, 2018

Stuttering (seems to be due to WS_POPUP removal?) #2307

Closed

lightningterror deleted the greg/vsync branch October 8, 2018 01:27

Greg/vsync #1950

Greg/vsync #1950

Conversation

gregory38 commented May 21, 2017

mirh commented May 21, 2017 • edited Loading

tabnk commented May 22, 2017

tabnk commented May 22, 2017

tabnk commented May 22, 2017 • edited Loading

mirh commented May 22, 2017 • edited Loading

tabnk commented May 22, 2017

ssakash left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

gregory38 commented May 25, 2017 • edited Loading

gregory38 commented May 29, 2017

tabnk commented May 29, 2017

gregory38 commented May 30, 2017

tabnk commented May 30, 2017 • edited by gregory38 Loading

mirh commented May 30, 2017

tabnk commented May 30, 2017

gregory38 commented May 30, 2017

tabnk commented May 30, 2017

mirh commented May 30, 2017

gregory38 commented May 30, 2017

tabnk commented May 30, 2017

gregory38 commented May 30, 2017

tabnk commented Jun 1, 2017

mirh commented Jun 1, 2017

tabnk commented Jun 1, 2017

gregory38 commented Jun 12, 2017

mirh commented Jun 12, 2017

gregory38 commented Jun 13, 2017

mirh commented Jun 13, 2017

gregory38 commented Jul 3, 2017

lightningterror commented Jul 4, 2017

gregory38 commented Jul 10, 2017

mirh commented May 21, 2017 •

edited

Loading

tabnk commented May 22, 2017 •

edited

Loading

mirh commented May 22, 2017 •

edited

Loading

gregory38 commented May 25, 2017 •

edited

Loading

tabnk commented May 30, 2017 •

edited by gregory38

Loading