Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSUI: Add Themes #12369

Merged
merged 1 commit into from
Mar 2, 2025
Merged

FSUI: Add Themes #12369

merged 1 commit into from
Mar 2, 2025

Conversation

kamfretoz
Copy link
Contributor

@kamfretoz kamfretoz commented Feb 28, 2025

Description of Changes

This PR adds themes to Big Picture Mode (ported from the Qt ones), I'm aiming for parity with the Qt themes, hence the draft status.
And possibly makes the entire theme system unified (Changing it on one side also affects the other) but thats for another day.

Some preview:
image
image
image
image
image
image
image
image

Rationale behind Changes

Feature parity with Qt, and just more eye-candy in general.

Suggested Testing Steps

Test for usability and readability issues, I've tested it before but there's a chance that i might miss something.

@kamfretoz kamfretoz marked this pull request as draft February 28, 2025 11:02
@kamfretoz kamfretoz force-pushed the FSUI-themes branch 2 times, most recently from 3dee488 to 0a840b9 Compare March 1, 2025 16:04
@kamfretoz kamfretoz marked this pull request as ready for review March 1, 2025 16:04
@kamfretoz
Copy link
Contributor Author

Ready for testing

@kamfretoz
Copy link
Contributor Author

Rebased.

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@F0bes F0bes merged commit 121920c into PCSX2:master Mar 2, 2025
12 checks passed
@kamfretoz kamfretoz deleted the FSUI-themes branch March 2, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants