FSUI: Add automatic mode to "Swap OK/Cancel" option #12366
Merged
+142
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanTheToaster
approved these changes
Mar 2, 2025
kamfretoz
approved these changes
Mar 2, 2025
F0bes
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add an auto mode to swapping X and O in BPM
This is based on either the user language, or the selected BIOS region
Also format the FSUI file
Rationale behind Changes
We can infer the users preference for the confirm button based on these settings
In future we can also set O as confirm when a switch controller is used, this will be after (or part of) the SDL3 pr
Suggested Testing Steps
Set "Swap OK/Cancel in Big Picture Mode" to Automatic
Change your language to Japanese/Chinese/Korean and check if X and O swap
Change your BIOS between an Asian and non-Asian region one (if you have multiple) and check if X and O swap.