Debugger: Set default breakpoint size to 4 #12356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
F0bes
approved these changes
Feb 26, 2025
|
Thanks for the PR! |
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Mar 2, 2025
--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk e394a4567392761346976cd490d2a2494b32b4e8 # Version: Commits on Feb 26, 2025
--------------------------------------------------------------------------------------------------------
Merge pull request #1863 from bulzipke/silence_warnings
Silence warnings,
------------------------------------------------------------------------------------------------
batocera-es-piboy.mk e394a4567392761346976cd490d2a2494b32b4e8 # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------------------
Merge pull request #1863 from bulzipke/silence_warnings
Silence warnings,
------------------------------------------------------------------------------------
citra.mk 4eded03d447b66160717ad50a9992b2a94e425b3 # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------
Android: Gradle 8.13,
------------------------------------------------------------------------------------------
dolphin-emu.mk f93781d91a90a937973534298b67b789f6a0db0a # Version: Commits on Feb 25, 2025
------------------------------------------------------------------------------------------
Merge pull request #13357 from Nejsplitter/master
GameSettings: Set ImmediateXFBEnable = False for Medal of Honor: Frontline,
------------------------------------------------------------------------------------------
duckstation.mk f7f17a077c704f4008feaf79938185e71bceb67d # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------------
Cheats: Add Enable8MBRAM option for patches,
-----------------------------------------------------------------------------------------
lightspark.mk f5218d620a4bdb88bb309cf932a2d8d0e0d10319 # Version: Commits on Feb 26, 2025
-----------------------------------------------------------------------------------------
revert previous commit as it seems to cause problems,
--------------------------------------------------------------------------------------
openmsx.mk d1b8b66da4aeabc10720157877f67c00f08b6a5f # Version: Commits on Feb 26, 2025
--------------------------------------------------------------------------------------
Also show changes in another color for 'slot viewer'
I think this completes:
Missing display of changed values in another color (red) after stepping
openMSX/openMSX#1657,
----------------------------------------------------
pcsx2.mk v2.3.183 # Version: Commits on Feb 26, 2025
----------------------------------------------------
- [Debugger: Set default breakpoint size to 4](PCSX2/pcsx2#12356)
,
-----------------------------------------------------------------------------------
play.mk e16703ac5872da861f3433e48484f40e7df45a1d # Version: Commits on Feb 26, 2025
-----------------------------------------------------------------------------------
Clear idle loop blocks upon reset.,
-------------------------------------------------------------------------------------
ppsspp.mk ab608ae159d44689ded0e6b6015a97b95e2e2a4d # Version: Commits on Feb 26, 2025
-------------------------------------------------------------------------------------
Merge pull request #20041 from hrydgard/more-libpng-nonsense
libpng full api: Remember to enable interlace handling, fix error handling,
------------------------------------------------------------------------------------
rpcs3.mk 4f3f155bbf541956555ba2992da052c17078f64d # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------
Update zstd to 1.5.7,
---------------------------------------------------------------
ruffle.mk nightly-2025-02-26 # Version: Commits on Feb 26, 2025
---------------------------------------------------------------
## What's Changed
* build(deps-dev): bump globals from 15.15.0 to 16.0.0 in /web by @dependabot in ruffle-rs/ruffle#19623
* build(deps-dev): bump the npm-minor group across 1 directory with 18 updates by @dependabot in ruffle-rs/ruffle#19628
**Full Changelog**: ruffle-rs/ruffle@nightly-2025-02-25...nightly-2025-02-26,
-----------------------------------------------------
ryujinx.mk 1.2.422 # Version: Commits on Feb 26, 2025
-----------------------------------------------------
# Canary builds:
These builds are experimental and may sometimes not work, use [regular builds](https://github.com/Ryubing/Ryujinx/releases/latest) instead if that sounds like something you don't want to deal with.
| Platform | Artifact |
|--|--|
| Windows 64-bit | [Canary Windows Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.422/ryujinx-canary-1.2.422-win_x64.zip) |
| Linux 64-bit | [Canary Linux Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.422/ryujinx-canary-1.2.422-linux_x64.tar.gz) |
| Linux ARM 64-bit | [Canary Linux ARM Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.422/ryujinx-canary-1.2.422-linux_arm64.tar.gz) |
| macOS | [Canary macOS Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.422/ryujinx-canary-1.2.422-macos_universal.app.tar.gz) |
**Full Changelog**: Ryubing/Ryujinx@Canary-1.2.421...Canary-1.2.422
--------------------------------------------------------------------------------------
shadps4.mk 63b50ff92c5afc5499a74d28dc802ef99f3e3ec7 # Version: Commits on Feb 26, 2025
--------------------------------------------------------------------------------------
OLED Theme (#2530)
* OLED Theme
* improve check box & text box visibility
* clang format
---------
Co-authored-by: smiRaphi <neogt404@gmail.com>,
---------------------------------------------------------------------------------------
thextech.mk 244622c56e735503b74a642c6e9940fa095ac474 # Version: Commits on Feb 26, 2025
---------------------------------------------------------------------------------------
Apply screen shake effects by location,
-------------------------------------------------------------------------------------------
xenia-native.mk 60318a5db66516614295146e5d455e4b6fda1be7 # Version: Commits on Feb 12, 2025
-------------------------------------------------------------------------------------------
[Module] Include XEX_SYSTEM_FLAGS in the log,
------------------------------------------------------------------------------------
box64.mk 5dadc513dbd9ffa84a28ab8c17f9a1cfd44877fc # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------
[WRAPPER] Updated auto-generated files,
---------------------------------------------------------------------------------------
corsixth.mk b4b45167a48b0b0812bf74e85369ca20e3dddd66 # Version: Commits on Feb 26, 2025
---------------------------------------------------------------------------------------
Merge pull request #2785 from lewri/update_announcer
Adjust random announcement target,
------------------------------------------------------------------------------------------
devilutionx.mk cee38198eb08229b9961c290a3d730325f0c7551 # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------------
Update Ukrainian translation (#7787)
* Update from code
* Ukrainian TL updates
* Translate new and updated strings
* Fix Naj's Light Plate TL
* Fix wrong apostrophe in Wounded Townsman dialogue (this caused it to not render)
* Reword Wirt's dialogue
* Change \unusual item damage\ TL to better reflect what it's doing
Thank you to @Maderator3000 for spotting these,
---------------------------------------------------------------------------------------
etlegacy.mk 175faadc0deea3773af96d007674849bee3c9367 # Version: Commits on Feb 26, 2025
---------------------------------------------------------------------------------------
game: Disable self-killing prevention on sv_cheats (#3040)
Is useful when devmap'ing.,
-------------------------------------------------------------------------------------------
jazz2-native.mk 2c5fa3af66ec43246fe14b88d740218f7810797e # Version: Commits on Feb 26, 2025
-------------------------------------------------------------------------------------------
Refactoring,
----------------------------------------------------------------------------------
stk.mk a0e309935758ca6899d1760f61ec0a278203d9d0 # Version: Commits on Feb 26, 2025
----------------------------------------------------------------------------------
Fix #5208,
-------------------------------------------------------
mame-src.mk mame0275 # Version: Commits on Feb 26, 2025
-------------------------------------------------------
,
---------------------------------------------------------------------------------------
hid-t150.mk f7ecb30c65ee5f7870e921bc0a2354df8e1e8100 # Version: Commits on Feb 25, 2025
---------------------------------------------------------------------------------------
bump version 1.0,
----------------------------------------------------------------------------------------
retroarch.mk 62f32e5f63b240e09b5bb6373038bd273d3e8034 # Version: Commits on Feb 26, 2025
----------------------------------------------------------------------------------------
Fetch translations from Crowdin,
-------------------------------------------------------------------------------------
libdof.mk 9213874e049c9b8903e1569b7d1b4d546e134ead # Version: Commits on Feb 26, 2025
-------------------------------------------------------------------------------------
misc: simplify SHAs. build libserialport for windows with v143 (#6),
---------------------------------------------------------------------------------------------
vulkan-samples.mk 43c23e56dab295e2e83903c69053927afbddac45 # Version: Commits on Feb 25, 2025
---------------------------------------------------------------------------------------------
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection (#1187)
* shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
* Incorporate review feedback: update comments and simpify code
* Add VK_EXT_validation_features and move VK_EXT_layer_settings extensions to ShaderDebugPrintf::create_instance()
* Fix VK_EXT_layer_settings string comparison in [HPP]Instance::[HPP]Instance()
* When VK_EXT_layer_settings extension is available don't enable it during instance creation
* Check for VK_EXT_layer_settings available vs. enabled in [HPP]Instance::[HPP]Instance()
* Use vk::ExtensionProperties vs. VkExtensionProperties in HPPInstance::HPPInstance()
* Update comments and explicitly request required GPU features for debugPrintfEXT
(cherry picked from commit 3365c7d974ae1cb7222cf35fdbe82accfa3fd926)
* Check for defined layer settings before chaining-in layerSettingsCreateInfo in [HPP]Instance::[HPP]Instance()
* Check VVL instance extensions for VK_EXT_layer_settings and use #define for VVL layer name
* Check for required GPU features otherwise throw exception with error message
* Update copyright year for all affected files
* Review: Remove shaderInt64 feature request, Use %v3f shader print format
* Fix copyright dates in updated shaders
* Update hwcpipe submodule to match main branch,
----------------------------------------------------------------------------------------
doomretro.mk 6623cb6e8900dc425dc03e75a8d1d58618a30801 # Version: Commits on Feb 26, 2025
----------------------------------------------------------------------------------------
Fix Clang warning,
------------------------------------------------------------------------------------------
xash3d-fwgs.mk 9f77b7dc46d88580df2ce3b207d6b4ad92b4239f # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------------
scripts: waifulib: enable HLSDK -mtune only on GCC and Clang, and not on Android,
--------------------------------------------------------------------------------------------------------
libretro-mupen64plus-next.mk 1b124af1eb05a6198acb8533b881d27c1c1bb6a1 # Version: Commits on Feb 26, 2025
--------------------------------------------------------------------------------------------------------
git subrepo push mupen64plus-core
subrepo:
subdir: \mupen64plus-core\
merged: \06fde7f12\
upstream:
origin: \https://github.com/libretro/mupen64plus-core.git\
branch: \master\
commit: \06fde7f12\
git-subrepo:
version: \0.4.6\
origin: \???\
commit: \???\,
------------------------------------------------------------------------------------------------
libretro-panda3ds.mk 7af8736f919ea26fa76b73ca824b7f42fdcbd108 # Version: Commits on Feb 26, 2025
------------------------------------------------------------------------------------------------
OLED theme config fix (#736)
Co-authored-by: smiRaphi <neogt404@gmail.com>,
--------------------------------------------------------------------------------------------
libretro-pcsx.mk ad2e709d6025ced5a09a67bbb51b4aeb6160ecec # Version: Commits on Feb 26, 2025
--------------------------------------------------------------------------------------------
patch: @@ -6,7 +6,7 @@
attributes:
label: PCSX-ReARMed Version
description: Version number of the emulator as shown in the menus and printed in logs.
- placeholder: r24l 3a52f747
+ placeholder: r25 ef0559d4
validations:
required: true
- type: input
--------------------------------------------------------------------------------------------
libretro-play.mk e16703ac5872da861f3433e48484f40e7df45a1d # Version: Commits on Feb 26, 2025
--------------------------------------------------------------------------------------------
Clear idle loop blocks upon reset.,
----------------------------------------------------------------------------------------------
libretro-ppsspp.mk ab608ae159d44689ded0e6b6015a97b95e2e2a4d # Version: Commits on Feb 26, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20041 from hrydgard/more-libpng-nonsense
libpng full api: Remember to enable interlace handling, fix error handling,
-------------------------------------------------------------------------------------
dhewm3.mk da119a30c682c90826720c94d60c2533ddba55aa # Version: Commits on Feb 25, 2025
-------------------------------------------------------------------------------------
Fix memory deallocation issue by using delete[] for arrays,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Title.
Rationale behind Changes
Size 4 is more inclusive than size 1. I was left scratching my head around the reason why I was unable to find the instructions manipulating a specific data in Yu-Gi-Oh! Duelists of the Roses, up until I changed the size to 4.
This will help those using the debugger in finding the instructions they're looking for. If a person desires exclusionary sizes such as 1 or 2, which is unlikely, they can change it so. And considering size 8 is unlikely to be searched for, then no need to expand the number to that. However, given that size 4 is able to find most instructions, then size 4 it is. This lessens the burden of having to enter 4 every time I'm setting a breakpoint, and helps the inexperienced, unwary users out. Now every LB, LH, SB, OR SH instruction can be found when setting a breakpoint, not only a small number of them.
Suggested Testing Steps
Not really needed. Besides, this size locates more instructions than it previously did.