FSUI: Add a config option to swap OK/Cancel within BPM #12342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanTheToaster
approved these changes
Feb 23, 2025
kamfretoz
approved these changes
Feb 23, 2025
Merged
F0bes
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a config option to swap OK/Cancel within BPM
Like the light theme toggle, this option only exists in BPM's settings panel.
Rationale behind Changes
Japanese PS2 titles often used circle as OK
With the upcoming update to SDL3, The button used for OK and cancel on Nintendo controllers will be swapped, this allows those users to swap that back.
Suggested Testing Steps
Test if the config option works
Test that the button prompts/tips are correct when swapped