Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Fix Japanese Game Titles #12158

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

nassau-tk
Copy link
Contributor

Description of Changes

I would chekced & fixed some Japanese titles.

Rationale behind Changes

Good Game List.

Suggested Testing Steps

@github-actions github-actions bot added the GameDB label Jan 5, 2025
name-en: "Shibai Muchi"
name: "しばいみち [USBマイク同梱版]"
name-sort: "しばいみち [USBまいくどうこんばん]"
name-en: "Shibai Muchi [with USB Mic]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it supposed to be spelled "Shibai Michi"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you right!!
Shibai Michi is Correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

region: "NTSC-J"
SCPS-11030:
name: "しばいみち"
name-sort: "しばいみち"
name-en: "Shibai Muchi [with Microphone]"
name-en: "Shibai Muchi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Right!!
Thank you for your help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

@@ -32247,7 +32247,7 @@ SLPM-55143:
SLPM-55144:
name: "NBA LIVE 08 [EA BEST HITS]"
name-sort: "NBA らいぶ08 [EA BEST HITS]"
name-en: "NBA Live 08 [EA BEST HITS]"
name-en: "NBA Live 08 [EA Best Hits]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason your changing this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority of tags written in English are not written in uppercase letters, so we simply unified them to match that.

There is no deeper meaning than that.

@@ -9930,7 +9930,7 @@ SCPS-55003:
SCPS-55004:
name: "ジャック×ダクスター 旧世界の遺産"
name-sort: "じゃっくんだくすたー きゅうせかいのいさん"
name-en: "Jak x Daxter - Kyuu Sekai no Isan"
name-en: "Jak and Daxter - Kyuu Sekai no Isan"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was already correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that the one written in Jak and Daxter was incorrect in terms of English?

Does that mean we should go with Jak x Daxter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

==> No change

@@ -8356,7 +8356,7 @@ SCPS-15030:
SCPS-15031:
name: "THE 京浜急行 ~Train Simulator Real~ [限定版]"
name-sort: "ざ けいひんきゅうこう Train Simulator Real [げんていばん]"
name-en: "Keihin Kyuukou - Train Simulator Real [Limited Edition], The"
name-en: "Keihin Kyuukou - Train Simulator Real, The [Limited Edition]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason your changing this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better imo.
Same thing should be made with PAPX-90502.

Copy link
Contributor Author

@nassau-tk nassau-tk Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason???
"The Train Simulator Real" is title.
It's not Include [Limited Editon] I think.
But, I 'm poor at english. lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think their actual names are "Train Simulator - The (train name)".
For example, take a look at pics in this page.
https://www.ebay.com/itm/186855110729

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, Right.
I forgot it [京浜急行= Keihin kyuukou]. lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, I originally did all the , The edits with find and replace. That's how it ended up like that.

@lightningterror
Copy link
Contributor

Is this ready for merge or still worked on?

@nassau-tk
Copy link
Contributor Author

nassau-tk commented Jan 9, 2025 via email

@nassau-tk
Copy link
Contributor Author

nassau-tk commented Jan 10, 2025

Is this ready for merge or still worked on?

It fixed.

@lightningterror lightningterror changed the title Fix Japanese Game Tiltes GameDB" Fix Japanese Game Titles Jan 15, 2025
@lightningterror lightningterror changed the title GameDB" Fix Japanese Game Titles GameDB: Fix Japanese Game Titles Jan 15, 2025
@lightningterror lightningterror merged commit 0090655 into PCSX2:master Jan 15, 2025
13 checks passed
SternXD pushed a commit to XboxEmulationHub/XBSX2 that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants